Skip to content

perf: Lazy load dashboard components #964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
juliusknorr merged 1 commit into from
Feb 9, 2023
Merged

perf: Lazy load dashboard components #964

juliusknorr merged 1 commit into from
Feb 9, 2023

Conversation

@juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Feb 8, 2023 •
edited
Loading

Save loading and evaluating larger amounts of javascript on the early page load.

@juliusknorr juliusknorr added the enhancement New feature or request label Feb 8, 2023
@juliusknorr juliusknorr requested a review from julien-nc February 8, 2023 16:34
@juliusknorr
Copy link
Member Author

juliusknorr commented Feb 8, 2023

@julien-nc Might be something nice for all the integration widgets at some point :)

@julien-nc
Copy link
Member

julien-nc commented Feb 8, 2023 •
edited
Loading

👍
It does not work with a subpath on my local setup. I see a request to
https://nextcloud.local/apps/notes/js/notes-commons.js?v=1fe6d2ef17a17417d45d
while it should be
https://nextcloud.local/dev/server26/apps/notes/js/notes-commons.js?v=1fe6d2ef17a17417d45d

julien-nc
julien-nc requested changes Feb 8, 2023
View reviewed changes
@juliusknorr
perf: Lazy load dashboard components
4f6c35d 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr juliusknorr requested a review from julien-nc February 8, 2023 19:55
julien-nc
julien-nc approved these changes Feb 8, 2023
View reviewed changes
Copy link
Member

@julien-nc julien-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@juliusknorr juliusknorr merged commit 06bf0e1 into master Feb 9, 2023
@juliusknorr juliusknorr deleted the perf/lazy-dashboard branch February 9, 2023 09:16
@juliusknorr juliusknorr mentioned this pull request Feb 15, 2023
Closed
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@julien-nc julien-nc julien-nc approved these changes

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@juliusknorr @julien-nc