Skip to content

Don't wrap setting in a div #1238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nickvergessen merged 1 commit into from
Aug 1, 2022
Merged

Don't wrap setting in a div #1238

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions js/notifications-settings.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion js/notifications-settings.js.map
View file
Open in desktop

Large diffs are not rendered by default.

54 changes: 26 additions & 28 deletions src/views/UserSettings.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,35 +19,33 @@
-->

<template>
<div>
<SettingsSection :title="t('notifications', 'Notifications')">
<div class="notification-frequency__warning">
<strong v-if="!config.is_email_set">{{ t('notifications', 'You need to set up your email address before you can receive notification emails.') }}</strong>
</div>
<p>
<label for="notify_setting_batchtime" class="notification-frequency__label">
{{ t('notifications', 'Send email reminders about unhandled notifications after:') }}
</label>
<select id="notify_setting_batchtime"
v-model="config.setting_batchtime"
class="notification-frequency__select"
@change="updateSettings()">
<option v-for="option in batchtime_options" :key="option.value" :value="option.value">
{{ option.text }}
</option>
</select>
</p>
<SettingsSection :title="t('notifications', 'Notifications')">
<div class="notification-frequency__warning">
<strong v-if="!config.is_email_set">{{ t('notifications', 'You need to set up your email address before you can receive notification emails.') }}</strong>
</div>
<p>
<label for="notify_setting_batchtime" class="notification-frequency__label">
{{ t('notifications', 'Send email reminders about unhandled notifications after:') }}
</label>
<select id="notify_setting_batchtime"
v-model="config.setting_batchtime"
class="notification-frequency__select"
@change="updateSettings()">
<option v-for="option in batchtime_options" :key="option.value" :value="option.value">
{{ option.text }}
</option>
</select>
</p>

<CheckboxRadioSwitch :checked.sync="config.sound_notification"
@update:checked="updateSettings">
{{ t('notifications', 'Play sound when a new notification arrives') }}
</CheckboxRadioSwitch>
<CheckboxRadioSwitch :checked.sync="config.sound_talk"
@update:checked="updateSettings">
{{ t('notifications', 'Play sound when a call started (requires Nextcloud Talk)') }}
</CheckboxRadioSwitch>
</SettingsSection>
</div>
<CheckboxRadioSwitch :checked.sync="config.sound_notification"
@update:checked="updateSettings">
{{ t('notifications', 'Play sound when a new notification arrives') }}
</CheckboxRadioSwitch>
<CheckboxRadioSwitch :checked.sync="config.sound_talk"
@update:checked="updateSettings">
{{ t('notifications', 'Play sound when a call started (requires Nextcloud Talk)') }}
</CheckboxRadioSwitch>
</SettingsSection>
</template>

<script>
Expand Down