Error: undefined variable $response in DAV storage

[ChristophWurst]

Steps to reproduce

1. Call

   server/lib/private/Files/Storage/DAV.php

   Line 829 in 8601bbc

   protected function convertException(Exception $e, $path = '') {

2. Hit

   server/lib/private/Files/Storage/DAV.php

   Line 855 in 8601bbc

   // TODO: only log for now, but in the future need to wrap/rethrow exception

3. Hit

   server/lib/private/Files/Storage/DAV.php

   Line 283 in 8601bbc

   return $response;

Expected behaviour

Condition is detected and handled (logged, ignored).

Actual behaviour

An unexpected condition is met and a non-existent variable is accessed.

Ref https://sentry.rullzer.com/sentry/nextcloud/issues/150 (for people with access).

[nextcloud-bot]

GitMate.io thinks possibly related issues are #4730 (Storage), #10665 (DAV Error in Nextcloud 14), #10417 (Fix undefined constant error for STATUS_SERVICE_UNAVAILABLE), #5684 (Error Message "undefined offset" with comments), and #9784 (Undefined index: {DAV:}getlastmodified at /var/www/html/lib/private/Files/Storage/DAV.php#582).

[ChristophWurst]

@nextcloud-bot nope, not even close …

[skjnldsv]

Still relevant @ChristophWurst ?

[kesselb]

Yes. See #16471 for example. We should not reach return $response if undefined.

[skjnldsv]

Nice!
So duplicate or relevant of #16471 @kesselb ?

[kesselb]

Relevant but not a duplicate. #16471 is running into the undefined return but the problem is with sabre/dav or alfresco. This issue is about the incomplete error handling.

[szaimen]

I suppose this issue is still valid? If not, please close this issue!