Allow symlinks configuration property

[cyberb]

Provide configuration setting for allowing symlinked data directory.

Currently it is hardcoded to false:
https://github.com/nextcloud/server/blob/master/lib/private/Files/Storage/Local.php#L55

Steps to reproduce

1. Create a directory on linux ext filesystem: mkdir/test
2. Create a symlink to that directory: ln -s /test /data
3. Use /data

Expected behaviour

I should be able to enable symlinks in a config, not by changing a php file variable.

Actual behaviour

Canot use symlinked data dir.

Server configuration

Operating system: Linux Debian (amd64, arm)

Web server: nginx

Database: postgresql

PHP version: 7.1.21

Nextcloud version: 14.0.0

Updated from an older Nextcloud/ownCloud or fresh install: fresh

Where did you install Nextcloud from: Syncloud

[kesselb]

server/config/config.sample.php

Lines 76 to 82 in b88ab75

	/**
	* Where user files are stored. The SQLite database is also stored here, when
	* you use SQLite.
	*
	* Default to ``data/`` in the Nextcloud directory.
	*/
	'datadirectory' => '/var/www/nextcloud/data',

Does not work for you?

[nextcloud-bot]

GitMate.io thinks possibly related issues are #4109 (Allow chunked public upload), #10121 (allow to disable encryption), #10120 (allow to disable encryption), #140 (Global OAuth Configuration), and #11075 (Allow root owned config.).

[cyberb]

Do you mean specify absolute path instead of a link in the config?

Not really, on Syncloud device you can activate different external disks and we do not want to change configs of all the apps on a device (not only Nextcloud) to point to.a new device dir.
To simplify that we use /data symlink (can be anything) and change the link to point to a selected disk dir.
Of cause we need to run post disk activate actions still per app, but I thought not changing data dirs in the app configs will be simpler.

It was working fine before v14, that is kind of another reason.

[Thaodan]

Would be a great feature when using systemd ProtectHome=yes because nextcloud thinks files inside of it are symlinks.

[dredkin]

I run nextcloud on my small server and after EVERY upgrade I have to manually edit this file. This is just ridiculous.
I need symlinks because my files are located out of nextcloud files folder.
And no, I will not move all my files there because nextcloud is not the only cloud engine I use to backup my files. And every single one cloud client I use works fine with symlinks, only nextcloud somehow just does not want to...
Is this because of security concerns? I don't need it. If I know, what I am doing, I have to have a possibility to do this. That's a FOSS spirit!

[gituser]

This PR is also relevant if you're running php-fpm in chroot environment.
Any update devs?

[kesselb]

A similar issue #10904. Probably a workaround for some of you: Create custom.config.php next to config.php like below.

<?php

$datadirectory = realpath('/path/to/symlink');
if ($datadirectory === false) {
    exit('failed to resolve datadirectory symlink');
}

$CONFIG['datadirectory'] = realpath($datadirectory);

Nextcloud updater (cli or web) do not read custom configuration files. That's usually not a problem because the configuration is merged. But if you use the above way please make sure to check the datadirectory in config.php before using the updater. Probably it's not the right path.

[skjnldsv]

@kesselb can you open a pr?

[kesselb]

No :) That's something for the config files.

[skjnldsv]

So, to develop?