Trying to access array offset on value of type `int` at `lib/private/Files/Node/Node.php#327`

[jean-io]

How to use GitHub

• Please use the 👍 reaction to show that you are affected by the same issue.
• Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
• Subscribe to receive notifications on status change and new comments.

Steps to reproduce

Hi, after upgrading not NC 18 and PHP 7.4, I have got some error messages that are apparently related to this new PHP version:

{"reqId":"AAA","level":3,"time":"20-Jan-2020 08:36:15","remoteAddr":"","user":"--","app":"PHP","method":"","url":"--","message":"Trying to access array offset on value of type int at /srv/http/nextcloud/lib/private/Files/Node/Node.php#327","userAgent":"--","version":"18.0.0.10"}
{"reqId":"BBB","level":3,"time":"20-Jan-2020 09:03:12","remoteAddr":"192.168.1.69","user":"admin","app":"PHP","method":"GET","url":"/apps/logreader/get?offset=0&count=50&levels=11111","message":"Trying to access array offset on value of type null at /srv/http/nextcloud/apps/logreader/lib/Log/LogIterator.php#78","userAgent":"Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:72.0) Gecko/20100101 Firefox/72.0","version":"18.0.0.10"}
{"reqId":"CCC","level":3,"time":"20-Jan-2020 09:10:44","remoteAddr":"192.168.1.69","user":"me","app":"PHP","method":"GET","url":"/apps/spreed/","message":"Trying to access array offset on value of type null at /srv/http/nextcloud/3rdparty/leafo/scssphp/src/Compiler.php#5230","userAgent":"Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:72.0) Gecko/20100101 Firefox/72.0","version":"18.0.0.10"}
{"reqId":"DDD","level":3,"time":"20-Jan-2020 09:12:32","remoteAddr":"192.168.1.69","user":"me","app":"PHP","method":"GET","url":"/apps/mail/","message":"Trying to access array offset on value of type null at /srv/http/nextcloud/3rdparty/leafo/scssphp/src/Compiler.php#5230","userAgent":"Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:72.0) Gecko/20100101 Firefox/72.0","version":"18.0.0.10"}
{"reqId":"EEE","level":3,"time":"20-Jan-2020 09:13:34","remoteAddr":"192.168.1.69","user":"jean","app":"PHP","method":"GET","url":"/apps/contacts/","message":"Trying to access array offset on value of type null at /srv/http/nextcloud/3rdparty/leafo/scssphp/src/Compiler.php#5230","userAgent":"Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:72.0) Gecko/20100101 Firefox/72.0","version":"18.0.0.10"}

Errors are from apps:

• AAA: core server
• BBB: Logreader (even if approuved in Test apps against PHP 7.4 #18146)
• CCC: Talk (not listed in Test apps against PHP 7.4 #18146)
• DDD: Mail (not listed in Test apps against PHP 7.4 #18146)
• EEE: Contact (not listed in Test apps against PHP 7.4 #18146)

Apprarently there is an issue in /3rdparty/leafo/scssphp/src/Compiler.php.

[J0WI]

Duplicate of #18996

[jean-io]

@J0WI OK it's a duplicate of #18996 for messages CCC, DDD and EEE.

But it's not a duplicate for log AAA and log BBB.

[J0WI]

Please open a separate issue in https://github.com/nextcloud/logreader for BBB.

[kesselb]

Thanks for reporting 👍

server/lib/private/Files/Node/Node.php

Lines 327 to 329 in 5bf3d1b

	if (!$path || $path[0] !== '/') {
	$path = '/' . $path;
	}

OK. Current implementation will prepend a '/' if the first character is not '/' or evaluates to false.

		if (!$path || strpos($path, '/') !== 0) {
			$path = '/' . $path;
		}

That's the same without the array integer warning. Actually the documentation says that isValidPath should be called with a string but somehow it's called with an integer. Probably a faulty type conversion somewhere.

Index: lib/private/Files/Node/Node.php
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
--- lib/private/Files/Node/Node.php	(revision 06c20a5138a0189047c26b6480cbf285a00bc449)
+++ lib/private/Files/Node/Node.php	(date 1579613413639)
@@ -324,7 +324,14 @@
 	 * @return bool
 	 */
 	public function isValidPath($path) {
-		if (!$path || $path[0] !== '/') {
+		if (is_int($path)) {
+			try {
+				throw new \LogicException('$path is a integer: ' . $path);
+			} catch (\LogicException $e) {
+				\OC::$server->getLogger()->logException($e);
+			}
+		}
+		if (!$path || strpos($path, '/') !== 0) {
 			$path = '/' . $path;
 		}
 		if (strstr($path, '/../') || strrchr($path, '/') === '/..') {

Would be nice to test this patch with additional logging. It will throw a exception if $path is an integer, catch the exception and forward it to the logs. We need the exception then to see where this faulty integer is coming from. Thanks 👍 (Don't forget the backups just in case)

Similar to: #18926

[jean-io]

Hi thank for re-opening this issue 👍

I am not comfortable with testing a patch on my only NC setup which is in production 😟

Can you reproduce this issue?
Anyway it does make sense to catch if $path is something else than a string before the condition $path[0] !== '/', right?

[kesselb]

Can you reproduce this issue?

No luck 🤷‍♂️

If you keep if (!$path || $path[0] !== '/') { and not replace with if (!$path || strpos($path, '/') !== 0) { there should be no impact. The try-catch logic (if $path is numeric) is there to draw a stack trace. Stack trace will show the requests path. I guess other people will run into this issue too. Probably someone else has a testing setup to apply the patch.

[MeiRos]

Hi @kesselb !
I got this in to my logs. Hopefully this is what you want to see.

{"reqId":"M9muiDyZWTtHrsJrBfJV","level":3,"time":"2020-01-23T19:05:01+00:00","remoteAddr":"","user":"--","app":"PHP","method":"","url":"--","message":"Trying to access array offset on value of type int at /home/nginx/domains/mydomain.net/public/lib/private/Files/Node/Node.php#327","userAgent":"--","version":"18.0.0.10"}
{"reqId":"4NEiKit2Q87PQK6Xm0E2","level":3,"time":"2020-01-23T19:09:10+00:00","remoteAddr":"11.22.33.44","user":"admin","app":"no app in context","method":"GET","url":"/apps/text/session/create?fileId=425&guestName=null&forceRecreate=false","message":{"Exception":"LogicException","Message":"$path is a integer: 425","Code":0,"Trace":[{"file":"/home/nginx/domains/mydomain.net/public/lib/private/Files/Node/Folder.php","line":59,"function":"isValidPath","class":"OC\\Files\\Node\\Node","type":"->"},{"file":"/home/nginx/domains/mydomain.net/public/lib/private/Files/Node/Folder.php","line":137,"function":"getFullPath","class":"OC\\Files\\Node\\Folder","type":"->"},{"file":"/home/nginx/domains/mydomain.net/public/lib/private/Files/SimpleFS/SimpleFolder.php","line":74,"function":"get","class":"OC\\Files\\Node\\Folder","type":"->"},{"file":"/home/nginx/domains/mydomain.net/public/apps/text/lib/Service/DocumentService.php","line":151,"function":"getFile","class":"OC\\Files\\SimpleFS\\SimpleFolder","type":"->"},{"file":"/home/nginx/domains/mydomain.net/public/apps/text/lib/Service/ApiService.php","line":87,"function":"createDocument","class":"OCA\\Text\\Service\\DocumentService","type":"->"},{"file":"/home/nginx/domains/mydomain.net/public/apps/text/lib/Controller/SessionController.php","line":49,"function":"create","class":"OCA\\Text\\Service\\ApiService","type":"->"},{"file":"/home/nginx/domains/mydomain.net/public/lib/private/AppFramework/Http/Dispatcher.php","line":170,"function":"create","class":"OCA\\Text\\Controller\\SessionController","type":"->"},{"file":"/home/nginx/domains/mydomain.net/public/lib/private/AppFramework/Http/Dispatcher.php","line":99,"function":"executeController","class":"OC\\AppFramework\\Http\\Dispatcher","type":"->"},{"file":"/home/nginx/domains/mydomain.net/public/lib/private/AppFramework/App.php","line":125,"function":"dispatch","class":"OC\\AppFramework\\Http\\Dispatcher","type":"->"},{"file":"/home/nginx/domains/mydomain.net/public/lib/private/AppFramework/Routing/RouteActionHandler.php","line":47,"function":"main","class":"OC\\AppFramework\\App","type":"::"},{"function":"__invoke","class":"OC\\AppFramework\\Routing\\RouteActionHandler","type":"->"},{"file":"/home/nginx/domains/mydomain.net/public/lib/private/Route/Router.php","line":299,"function":"call_user_func"},{"file":"/home/nginx/domains/mydomain.net/public/lib/base.php","line":1008,"function":"match","class":"OC\\Route\\Router","type":"->"},{"file":"/home/nginx/domains/mydomain.net/public/index.php","line":38,"function":"handleRequest","class":"OC","type":"::"}],"File":"/home/nginx/domains/mydomain.net/public/lib/private/Files/Node/Node.php","Line":330,"CustomMessage":"--"},"userAgent":"Mozilla/5.0 (X11; CrOS x86_64 12607.58.0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/79.0.3945.86 Safari/537.36","version":"18.0.0.10"}
{"reqId":"4NEiKit2Q87PQK6Xm0E2","level":3,"time":"2020-01-23T19:09:10+00:00","remoteAddr":"11.22.33.44","user":"admin","app":"no app in context","method":"GET","url":"/apps/text/session/create?fileId=425&guestName=null&forceRecreate=false","message":{"Exception":"LogicException","Message":"$path is a integer: 425","Code":0,"Trace":[{"file":"/home/nginx/domains/mydomain.net/public/lib/private/Files/Node/Folder.php","line":59,"function":"isValidPath","class":"OC\\Files\\Node\\Node","type":"->"},{"file":"/home/nginx/domains/mydomain.net/public/lib/private/Files/Node/Folder.php","line":181,"function":"getFullPath","class":"OC\\Files\\Node\\Folder","type":"->"},{"file":"/home/nginx/domains/mydomain.net/public/lib/private/Files/SimpleFS/SimpleFolder.php","line":84,"function":"newFile","class":"OC\\Files\\Node\\Folder","type":"->"},{"file":"/home/nginx/domains/mydomain.net/public/apps/text/lib/Service/DocumentService.php","line":153,"function":"newFile","class":"OC\\Files\\SimpleFS\\SimpleFolder","type":"->"},{"file":"/home/nginx/domains/mydomain.net/public/apps/text/lib/Service/ApiService.php","line":87,"function":"createDocument","class":"OCA\\Text\\Service\\DocumentService","type":"->"},{"file":"/home/nginx/domains/mydomain.net/public/apps/text/lib/Controller/SessionController.php","line":49,"function":"create","class":"OCA\\Text\\Service\\ApiService","type":"->"},{"file":"/home/nginx/domains/mydomain.net/public/lib/private/AppFramework/Http/Dispatcher.php","line":170,"function":"create","class":"OCA\\Text\\Controller\\SessionController","type":"->"},{"file":"/home/nginx/domains/mydomain.net/public/lib/private/AppFramework/Http/Dispatcher.php","line":99,"function":"executeController","class":"OC\\AppFramework\\Http\\Dispatcher","type":"->"},{"file":"/home/nginx/domains/mydomain.net/public/lib/private/AppFramework/App.php","line":125,"function":"dispatch","class":"OC\\AppFramework\\Http\\Dispatcher","type":"->"},{"file":"/home/nginx/domains/mydomain.net/public/lib/private/AppFramework/Routing/RouteActionHandler.php","line":47,"function":"main","class":"OC\\AppFramework\\App","type":"::"},{"function":"__invoke","class":"OC\\AppFramework\\Routing\\RouteActionHandler","type":"->"},{"file":"/home/nginx/domains/mydomain.net/public/lib/private/Route/Router.php","line":299,"function":"call_user_func"},{"file":"/home/nginx/domains/mydomain.net/public/lib/base.php","line":1008,"function":"match","class":"OC\\Route\\Router","type":"->"},{"file":"/home/nginx/domains/mydomain.net/public/index.php","line":38,"function":"handleRequest","class":"OC","type":"::"}],"File":"/home/nginx/domains/mydomain.net/public/lib/private/Files/Node/Node.php","Line":330,"CustomMessage":"--"},"userAgent":"Mozilla/5.0 (X11; CrOS x86_64 12607.58.0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/79.0.3945.86 Safari/537.36","version":"18.0.0.10"}

[kesselb]

Thanks @MeiRos 👍

https://github.com/nextcloud/text/blob/936225d69d2ac0546d4d83048817273950979193/lib/Service/DocumentService.php#L150-L154

cc @juliushaertl Please pass a string to getFile and newFile ;)