"Limit to groups" changes setting for all apps, not just the selected

[RogoTe]

I tried to use the "Limit to groups" settings to disable some apps for a certain user group, when I stumbled upon the following bug: everytime I check or uncheck this field for one app, the same setting is applied to all other apps as well. The list of groups is not affected, it behaves like expected.
Not shure if this issue belongs here or to nextcloud/server.

Details

• Browser and browser version: Firefox 74.0.1 and Safari 13.1 on MacOS 10.15.4

JavaScript Console Output

marked(): sanitize and sanitizer parameters are deprecated since version 0.7.0, should not be used and will be removed in the future. Read more here: https://marked.js.org/#/USING_ADVANCED.md#options vue-7.js:1:23339

Steps to reproduce

1. Log in to Nextcloud as Administrator, go to Apps
2. select one of the installed apps, e.g. Calendar
3. Check whether "Limit to groups" is checked
4. Select another app, e.g. Tasks
5. Click "Limit to groups" to change the setting
6. Go back to first app (Calendar) --> you will see the setting for "Limit to groups" changed according to the second app

[mario]

I'll move this to server as I think it belongs there.

[Rello]

I can confirm this.
As far as I can see its a display issue. whatever setting you see first (see an app with/without), this is also shown on all others.
THe checked setting is not reinitialized when selecting another app

[szaimen]

This is just a display error which becomes clear after you reload the side but it should be fixed nonetheless.

[nroach44]

This still seems to be occurring in 26.0.3.

[Rello]

@szaimen I think the issue is that one:

server/apps/settings/src/mixins/AppManagement.js

Line 72 in 0e69a6a

this.groupCheckedAppsData = true

this.groupCheckedAppsData is set on the initial load of the app list (mounted())
this is then always true for all apps and being checked here.

https://github.com/nextcloud/server/blob/master/apps/settings/src/mixins/AppManagement.js#L81

could this be the issue?

[szaimen]

Yes, looks like it. cc @nextcloud/server-frontend