Remove constructor from IStorage interface

[come-nc]

\OCP\Files\Storage\IStorage and \OCP\Files\Storage contain a constructor, which triggers errors and warninigs en classes implementing those that other parameters in their constructor, like \OC\Encryption\Keys\Storage.

I’m pretty sure there is no reason to have these constructors in the interfaces, unless we sometime build an instance without knowing which class it is?

[CarlSchwan]

yes please kill it with 🔥

[ArtificialOwl]

[icewind1991]

unless we sometime build an instance without knowing which class it is?

server/lib/private/Files/Storage/StorageFactory.php

Line 82 in 215aef3

return $this->wrap($mountPoint, new $class($arguments));

[come-nc]

unless we sometime build an instance without knowing which class it is?

server/lib/private/Files/Storage/StorageFactory.php

Line 82 in 215aef3

return $this->wrap($mountPoint, new $class($arguments));

Thank you for the reference.
But is seems we do not actually use this function, or at least not in core?
How will that work with encryption storage which have other parameters?

It seems the wrap method should be enough, I do not see the value in building the instance this way.