external audio playback is broken

[szaimen]

See

[szaimen]

cc @max-nextcloud @skjnldsv probably due to using the viewer for public previews, no?

[max-nextcloud]

Actually we are not using the viewer for audio mimetypes yet.

Tried locally and mp3 file had hasPreview and then tried to load a preview image for the audio file.
Enabling the viewer for audio files worked pretty well. However the layout does not really work:

In particular the settings menu will be totally hidden by the top menu

[szaimen]

Enabling the viewer for audio files worked pretty well. However the layout does not really work:

In particular the settings menu will be totally hidden by the top menu

Can you base this on top of my fix public view branch and push your changes to it? I can have a look at the problem then...

[szaimen]

Another option would be merging my PR and creating a new PR for this afterwards. WDYT?

[max-nextcloud]

Another option would be merging my PR and creating a new PR for this afterwards. WDYT?

Yes... let's go step by step. These seem to be independent problems.

[max-nextcloud]

I'll open another PR with my change.

[szaimen]

Can you maybe review my PR then? This should unblock this one...

[szaimen]

I'll open another PR with my change.

okay, please note that you will likely run into conflicts though if you open it before my change is merged...

[max-nextcloud]

I'll open another PR with my change.

okay, please note that you will likely run into conflicts though if you open it before my change is merged...

https://github.com/nextcloud/server/pull/34051/files

For now it's a single line change that is independent of what you are doing.

[szaimen]

For now it's a single line change that is independent of what you are doing.

okay. After the other PR is merged we still need to rebase in order to be able to adjust the styling...