Theming is broken in 12.0.1

[mwaeckerlin]

Since Upgrade from Nextcloud 12.0.0 to 12.0.1, theming is not shown anymore, even though it is still correctly configured in the background:

Configuration is still ok:

Login page does not show configured settings, but the default:

[MorrisJobke]

cc @nextcloud/theming

[danxuliu]

I could not replicate this on a fresh Nextcloud 12.0.1 installation.

I have also tested updating a Nextcloud 12.0.0 instance to Nextcloud 12.0.1 and I could not replicate it either, although it was not a real instance (it was created fresh in Docker and then updated). Here are the steps that I used:

1. In a GNU/Linux console, run docker run --detach --volume nextcloud-custom_apps:/var/www/html/custom_apps --volume nextcloud-config:/var/www/html/config --volume nextcloud-data:/var/www/html/data --publish 8080:80 --name nextcloud-test nextcloud:12.0.0 to create a new Nextcloud 12.0.0 instance.
2. In the browser, visit localhost:8080, set an admin user and password and finish the setup. The admin user is logged in to the Files app.
3. In the browser, open the Theming app and set a custom colour.
4. In the browser, log out; the colour is used in the login button.
5. In a GNU/Linux console, run docker stop nextcloud-test && docker rm nextcloud-test to stop and remove the Nextcloud instance.
6. In a GNU/Linux console, run docker run --detach --volume nextcloud-custom_apps:/var/www/html/custom_apps --volume nextcloud-config:/var/www/html/config --volume nextcloud-data:/var/www/html/data --publish 8080:80 --name nextcloud-test nextcloud:12.0.1 to update the previous Nextcloud instance to 12.0.1 (because the config and data were kept in Docker volumes and thus reused by the new instance).
7. In the browser, visit localhost:8080. Click Start update to... well, start the update :-P Once finished you are redirected to the login page. The button has the custom colour (and, if it is not, refreshing the page several times eventually sets the proper colour).

Note that in 12.0.1 there was a bug (fixed in 12.0.3) due to which the Theming app did not preview the colour as it should (and never removed the Loading preview message nor the loading icon); however, even if the preview did not work, the colour was properly set and was shown once refreshed in the login button, the header and so on.

@mwaeckerlin, could you be hitting a browser cache problem?

[lenusch]

i have theming Problems aswell: #6172
Since newer Versions i can't changed Background anymore.

12.0.2

[mwaeckerlin]

@danxuliu, no, no caching problem, problem is still unsolved. The theming does not work anymore, even tough the configuration is still there.

URL to the nextcloud instance: https://ggr.mrw.cloud

I'm using docker too, from my own Dockerfile, that implements a special app:

https://github.com/mwaeckerlin/ggrwinti

which inherits from my default nextcloud Dockerfile:

https://github.com/mwaeckerlin/nextcloud

which inherits from my default Ubuntu base Dockerfile:

https://github.com/mwaeckerlin/ubuntu-base

Persistent volumes are:

• /var/www/nextcloud/data
• /var/www/nextcloud/config

And of course, the database is in a persistent volume.

This is how it was started:

docker run -d --restart unless-stopped \
    --name ggrwinti-volume \
    mwaeckerlin/ggrwinti sleep infinity
docker run -d --restart unless-stopped \
    --name ggrwinti-mysql-volume \
    mysql sleep infinity
docker run -d --restart unless-stopped \
    --name ggrwinti-mysql \
    --volumes-from ggrwinti-mysql-volume \
    -e 'MYSQL_DATABASE=nextcloud' \
    -e 'MYSQL_USER=nextcloud' \
    -e 'MYSQL_PASSWORD=xxx' \
    -e 'MYSQL_RANDOM_ROOT_PASSWORD=1' \
    mysql
docker run -d --restart unless-stopped \
    --name ggrwinti \
    -p 8002:80/tcp \
    --volumes-from ggrwinti-volume \
    --link ggrwinti-mysql:mysql \
    -e 'ADMIN_PWD=xxx' \
    mwaeckerlin/ggrwinti

Thus is how it was upgraded:

docker pull mwaeckerlin/ggrwinti
docker rm -f ggrwinti
docker run -d --restart unless-stopped \
    --name ggrwinti \
    -p 8002:80/tcp \
    --volumes-from ggrwinti-volume \
    --link ggrwinti-mysql:mysql \
    -e 'ADMIN_PWD=xxx' \
    mwaeckerlin/ggrwinti

[mwaeckerlin]

What I see as difference to your code, @danxuliu, is that I do note keep /var/www/html/custom_apps as persistent volume, a directory path, that does not even exist in my installation:

user@host:~$ docker exec -itu www-data ggrwinti bash
www-data@docker[c2d70b0d9048]:~/nextcloud$ ls custom_apps
ls: cannot access 'custom_apps': No such file or directory
www-data@docker[c2d70b0d9048]:~/nextcloud$ pwd
/var/www/nextcloud

[MorrisJobke]

Could you change the color to a different one and then back again? Maybe this is a problem within the theming cache buster.

[lenusch]

I can change Color but not Background :-)

[mwaeckerlin]

Changed to red, nothing happens. «Load preview» rotates for ever, color is not changed:

When I leave the setting and come back, the new red color is in the dialog, but not in the theme, theme is still default blue. The settings are stored, but not applied to the theme:

(I cannot upload screenshots, github fails with: «Something went really wrong, and we can’t process that file. Try again.» → Github-Upload fails with firefox, works in Chromium)

[mwaeckerlin]

Nothing works for me, neither the name. nor the url, nor the slogan, nor the color, nor th logo, nor the image. :(

[mwaeckerlin]

Same in Chromium as in Firefox: «Load preview» rotates for ever, color is not changed, so it's not a browser related problem.

[MorrisJobke]

@juliushaertl Any idea?

[juliusknorr]

@mwaeckerlin Any errors in your log. Strage is, that the generated theming.css file on the instance you've mentioned above doesn't contain anything.