Skip to content

Add "addVendorScript/Style" to public interface Utility class #889

Description

@janis91

Steps to reproduce

1 . Use a vendorscript or vendorstyle in your own app:

OC_Util::addVendorScript('select2/select2');
OC_Util::addVendorStyle('select2/select2');

2 . ./occ app:check-code $APP_NAME -c private -c strong-comparison

Expected behaviour

app check should return without errors

Actual behaviour

OC_Util - Static method of private class must not be called

Server configuration

Operating system:
Ubuntu 14.04
Web server:
ncdev php test server
Database:
postgre
PHP version:
7
Nextcloud version: (see Nextcloud admin page)
11.0
Updated from an older Nextcloud/ownCloud or fresh install:
no
Where did you install Nextcloud from:
ncdev (git)

I think it would be a improvement to add the addVendorScript and addVendorStyle functions to the OCP\Util public interface, such that the app:check of occ isn't crying anymore.
Or do you know another way to include vendor script and style which is not harming the code check?

If the extension of the OCP\Util is the best solution, I could contribute...

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementstaleTicket or PR with no recent activity

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions