Skip to content

Newdav tagsplugin#1525

Merged
nickvergessen merged 4 commits into
masterfrom
newdav-tagsplugin
Oct 6, 2016
Merged

Newdav tagsplugin#1525
nickvergessen merged 4 commits into
masterfrom
newdav-tagsplugin

Conversation

@LukasReschke

Copy link
Copy Markdown
Member

From owncloud/core#26098

Let's see if the tests pass 🙈

@LukasReschke LukasReschke added 3. to review Waiting for reviews downstream labels Sep 26, 2016
@LukasReschke LukasReschke added this to the Nextcloud 11.0 milestone Sep 26, 2016
@mention-bot

Copy link
Copy Markdown

@LukasReschke, thanks for your PR! By analyzing the annotation information on this pull request, we identified @davitol, @SergioBertolinSG and @rullzer to be potential reviewers

@ChristophWurst

Copy link
Copy Markdown
Member

rebased to resolve conflicts

@codecov-io

codecov-io commented Oct 3, 2016

Copy link
Copy Markdown

Current coverage is 30.58% (diff: 0.00%)

Merging #1525 into master will decrease coverage by 0.03%

@@             master      #1525   diff @@
==========================================
  Files          1081       1081          
  Lines         60019      60314   +295   
  Methods        6808       6845    +37   
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          18378      18450    +72   
- Misses        41641      41864   +223   
  Partials          0          0          

Sunburst

Diff Coverage File Path
0% apps/dav/lib/Server.php

Powered by Codecov. Last update 66ae438...09a90b4

Vincent Petry and others added 4 commits October 5, 2016 08:19
This makes it possible to retrieve and PROPPATCH the favorite info

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
@rullzer
rullzer force-pushed the newdav-tagsplugin branch from 7a41729 to 09a90b4 Compare October 5, 2016 06:19
@MorrisJobke

Copy link
Copy Markdown
Member

Tested and works 👍

$ curl -H 'Depth:1' -u admin:admin -H 'Content-Type:text/xml; charset=UTF-8' -X PROPFIND 'http://localhost:7000/remote.php/webdav/' --data-binary '<?xml version="1.0" encoding="UTF-8"?><D:propfind xmlns:D="DAV:"><D:prop><D:resourcetype/><D:getlastmodified/><favorite xmlns="http://owncloud.org/ns"/><D:creationdate/><id xmlns="http://owncloud.org/ns"/><D:getcontentlength/><D:displayname/><D:quota-available-bytes/><D:getetag/><permissions xmlns="http://owncloud.org/ns"/><D:quota-used-bytes/><D:getcontenttype/></D:prop></D:propfind>'

Then there is a <oc:favorite>1</oc:favorite> element, that is set to 1 if the favorite is set or empty if not set.

@MorrisJobke

Copy link
Copy Markdown
Member

@icewind1991 @rullzer Mind to have a look?

@nickvergessen

Copy link
Copy Markdown
Member

Tested and works 👍

$ curl -H 'Depth:1' -u admin:admin -H 'Content-Type:text/xml; charset=UTF-8' -X PROPFIND 'http://localhost:7000/remote.php/webdav/' --data-binary '<?xml version="1.0" encoding="UTF-8"?><D:propfind xmlns:D="DAV:"><D:prop><D:resourcetype/><D:getlastmodified/><favorite xmlns="http://owncloud.org/ns"/><D:creationdate/><id xmlns="http://owncloud.org/ns"/><D:getcontentlength/><D:displayname/><D:quota-available-bytes/><D:getetag/><permissions xmlns="http://owncloud.org/ns"/><D:quota-used-bytes/><D:getcontenttype/></D:prop></D:propfind>'

Then there is a oc:favorite1/oc:favorite element, that is set to 1 if the favorite is set or empty if not set.

Works already before.

http://localhost:7000/remote.php/dav/files/admin/ is what has been fixed.

@nickvergessen

Copy link
Copy Markdown
Member

👍

@nickvergessen
nickvergessen merged commit f6e8da1 into master Oct 6, 2016
@nickvergessen
nickvergessen deleted the newdav-tagsplugin branch October 6, 2016 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants