Skip to content

Integration tests qa 222 - #1546

Merged
LukasReschke merged 3 commits into
masterfrom
integration-tests-qa-222
Oct 3, 2016
Merged

Integration tests qa 222#1546
LukasReschke merged 3 commits into
masterfrom
integration-tests-qa-222

Conversation

@LukasReschke

Copy link
Copy Markdown
Member

@LukasReschke LukasReschke added 3. to review Waiting for reviews downstream labels Sep 27, 2016
@LukasReschke LukasReschke added this to the Nextcloud 11.0 milestone Sep 27, 2016
@mention-bot

Copy link
Copy Markdown

@LukasReschke, thanks for your PR! By analyzing the annotation information on this pull request, we identified @SergioBertolinSG, @rullzer and @nickvergessen to be potential reviewers

@MorrisJobke MorrisJobke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are failing

And user "user0" adds a file of 93 bytes to "/prueba.txt"
When as "user0" gets properties of folder "/" with
|{DAV:}quota-available-bytes|
Then the single response should contain a property "{DAV:}quota-available-bytes" with value "600"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Property "{DAV:}quota-available-bytes" found with value "592", expected "600" (Exception)

@nickvergessen nickvergessen Sep 29, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess that is because our welcome.txt has a different content

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep it is because Nextcloud has a letter more than ownCloud

And file "user0.txt" of user "user0" is shared with user "user1"
When as "user1" gets properties of folder "/" with
|{DAV:}quota-available-bytes|
Then the single response should contain a property "{DAV:}quota-available-bytes" with value "693"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Property "{DAV:}quota-available-bytes" found with value "685", expected "693" (Exception)

@MorrisJobke MorrisJobke added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Sep 28, 2016
SergioBertolinSG and others added 3 commits October 2, 2016 21:16
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
Nextcloud has a letter (byte) more than ownCloud. So update test
@rullzer
rullzer force-pushed the integration-tests-qa-222 branch from 59ba34c to 554d0c5 Compare October 2, 2016 19:18
@MorrisJobke

Copy link
Copy Markdown
Member

👍

@MorrisJobke MorrisJobke added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Oct 3, 2016
@codecov-io

Copy link
Copy Markdown

Current coverage is 30.59% (diff: 100%)

Merging #1546 into master will not change coverage

@@             master      #1546   diff @@
==========================================
  Files          1081       1081          
  Lines         60020      60020          
  Methods        6808       6808          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits          18362      18362          
  Misses        41658      41658          
  Partials          0          0          

Sunburst

Powered by Codecov. Last update 6297d20...554d0c5

@LukasReschke
LukasReschke merged commit a62f6fa into master Oct 3, 2016
@LukasReschke
LukasReschke deleted the integration-tests-qa-222 branch October 3, 2016 10:41
@MorrisJobke

Copy link
Copy Markdown
Member

signed off check failed ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants