Skip to content

[stable16] Sharing in list: Use .hidden-visually instead of display:none for accessibility, fix #11661 #15981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
skjnldsv merged 1 commit into from
Jun 18, 2019
Merged

[stable16] Sharing in list: Use .hidden-visually instead of display:none for accessibility, fix #11661 #15981

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions apps/files/css/files.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -541,8 +541,15 @@ a.action > img {
opacity: .3;
&.action-share {
padding: 17px 14px;
> span:not(.icon) {
display: none;
&.permanent:not(.shared-style) .icon-shared + span {
/* hide text of the share action */
/* .hidden-visually for accessbility */
position: absolute;
left:-10000px;
top: auto;
width: 1px;
height: 1px;
overflow: hidden;
}
.avatar {
display: inline-block;
Expand Down Expand Up @@ -752,7 +759,7 @@ table.dragshadow td.size {
border-radius: 0;
background-color: transparent;
z-index:1;

> a[href='#'] {
// if no link is set, no mouse feedback
box-shadow: none !important;
Expand Down
10 changes: 8 additions & 2 deletions apps/files/css/mobile.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,14 @@ table.multiselect thead {
margin-right: 6px;
}
/* hide text of the share action on mobile */
#fileList a.action-share span:not(.icon) {
display: none !important;
/* .hidden-visually for accessbility */
#fileList a.action-share span:not(.icon):not(.avatar) {
position: absolute;
left:-10000px;
top: auto;
width: 1px;
height: 1px;
overflow: hidden;
}


Expand Down