Bump sabre#1792
Merged
Merged
Conversation
rullzer
added
enhancement
3. to review
|
@rullzer, thanks for your PR! By analyzing the history of the files in this pull request, we identified @DeepDiver1975, @schiessle and @LukasReschke to be potential reviewers. |
rullzer
force-pushed
the
bump_sabre
branch
2 times, most recently
from
a91b241 to
595384b
Compare
Member
It says 🚫 ❗️ |
Member
Author
|
Yeah I know. Have been messing with it to get the caldav intergration tests happy. But no real luck so far |
* Update sabre/dav to 3.2.0 * Adjust code to work with sabre/dav 3.2.0 and it's dependencies * Adding own CalDAV plugin to fix calendar home property * Test if there is a user logged in when listing files home * Update sabre version used by integration tests * Disable unauthenticated DAV access This is needed to make Sabre 3.2 behave like we did before. Eventually we should integrate better with the ACL plugin which itself should implement an auth failure when appropriate. ===== * Fixed so cherry-pick was succesfull Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
* Made sure delete from self works again (and is tested) Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Current coverage is 57.87% (diff: 93.75%)@@ master #1792 diff @@
==========================================
Files 1094 1099 +5
Lines 62793 63539 +746
Methods 6994 7147 +153
Messages 0 0
Branches 0 0
==========================================
+ Hits 36289 36776 +487
- Misses 26504 26763 +259
Partials 0 0
|
MorrisJobke
added
3. to review
Member
Author
|
Whee CI is happy. Review time! |
Member
|
Works here fine 👍 I did some smoke testing with WebDAV and some file operations. |
Member
|
@nickvergessen could we get smashbox for this? |
Member
|
Smashbox passed ✅ |
LukasReschke
requested changes
Nov 9, 2016
LukasReschke
left a comment
LukasReschke
left a comment
Member
There was a problem hiding this comment.
Looks good. Two new files are not really being tested. Will add myself quickly :)
| * @param string $principal | ||
| * @return array | ||
| */ | ||
| protected function getAddressesForPrincipal($principal) { |
Member
There was a problem hiding this comment.
Missing tests. Will quickly add myself.
| /** | ||
| * @inheritdoc | ||
| */ | ||
| function getCalendarHomeForPrincipal($principalUrl) { |
Member
There was a problem hiding this comment.
Missing tests. Will quickly add myself.
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
LukasReschke
approved these changes
Nov 9, 2016
Member
|
Tests added and third-party rebased. LGTM. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses: owncloud/core#26115
Lets see what CI thinks of this!