Skip to content

print the backup codes tab and not the current one #2704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rullzer merged 2 commits into from
Feb 15, 2017
+11 −9
Merged

print the backup codes tab and not the current one #2704

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e111015
print and close the new tab, not the current one when printing backup…
ChristophWurst Dec 15, 2016
3295fe2
add title to backup codes print page
ChristophWurst Dec 20, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 11 additions & 9 deletions apps/twofactor_backupcodes/js/settingsview.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,16 +59,16 @@
total: this._total,
used: this._used,
codes: this._codes,
download: this._getDownloadDataHref()
download: this._getDownloadData()
}));
},
_getDownloadDataHref: function () {
_getDownloadData: function () {
if (!this._codes) {
return '';
}
return 'data:text/plain,' + encodeURIComponent(_.reduce(this._codes, function (prev, code) {
return prev + code + "\r\n";
}, ''));
return _.reduce(this._codes, function (prev, code) {
return prev + code + "<br>";
}, '');
},
_load: function () {
this._loading = true;
Expand Down Expand Up @@ -113,10 +113,12 @@
});
},
_onPrintBackupCodes: function () {
var url = this._getDownloadDataHref();
window.open(url, t('twofactor_backupcodes', 'Nextcloud backup codes'));
window.print();
window.close();
var data = this._getDownloadData();
var newTab = window.open('', t('twofactor_backupcodes', 'Nextcloud backup codes'));
newTab.document.write('<h1>' + t('twofactor_backupcodes', 'Nextcloud backup codes') + '</h1>');
newTab.document.write(data);

@ChristophWurst ChristophWurst Dec 20, 2016

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @LukasReschke for possible security implications of writing to the document directly

newTab.print();
newTab.close();
}
});

Expand Down