Skip to content

Testing md5home (#26854)#2820

Merged
LukasReschke merged 1 commit into
masterfrom
testing-md5home
Dec 23, 2016
Merged

Testing md5home (#26854)#2820
LukasReschke merged 1 commit into
masterfrom
testing-md5home

Conversation

@LukasReschke

Copy link
Copy Markdown
Member
  • Allow clearing default user backends in config.php

When specifying "user_backends" in config.php, a new option "default"
when set to false will prevent the default user backend to be
registered. The default one is the database backend.
This makes it possible to select exclusive user backends from apps.

  • Testing app provides test user backend for alternative homes

The backend provide md5 result to getHome()

  • Only md5 the user home when it's not the admin

Signed-off-by: Lukas Reschke lukas@statuscode.ch

From owncloud/core#26854

* Allow clearing default user backends in config.php

When specifying "user_backends" in config.php, a new option "default"
when set to false will prevent the default user backend to be
registered. The default one is the database backend.
This makes it possible to select exclusive user backends from apps.

* Testing app provides test user backend for alternative homes

The backend provide md5 result to getHome()

* Only md5 the user home when it's not the admin

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
@LukasReschke LukasReschke added 3. to review Waiting for reviews downstream labels Dec 22, 2016
@LukasReschke LukasReschke added this to the Nextcloud 12.0 milestone Dec 22, 2016
@mention-bot

Copy link
Copy Markdown

@LukasReschke, thanks for your PR! By analyzing the history of the files in this pull request, we identified @rullzer, @icewind1991 and @blizzz to be potential reviewers.

@schiessle

Copy link
Copy Markdown
Member

Not sure if I understand this correctly, this is only used for testing right? In this case I would prefer to keep the app out of the main (productive) repository and put it in a separate repository instead.

@LukasReschke

LukasReschke commented Dec 22, 2016

Copy link
Copy Markdown
Member Author

Not sure if I understand this correctly, this is only used for testing right? In this case I would prefer to keep the app out of the main (productive) repository and put it in a separate repository instead.

The app is already in the main repo and used for some other stuff: https://github.com/nextcloud/server/tree/master/apps/testing

Advantage of having it here is that we don't have to commit to the testing app repo once a day to trigger a CI build to verify that the stuff still runs. I don't have any big feelings about this one here.

@LukasReschke
LukasReschke merged commit 91c87d3 into master Dec 23, 2016
@LukasReschke
LukasReschke deleted the testing-md5home branch December 23, 2016 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants