Properly expire ext storage versions (#26601)#2824
Merged
Conversation
|
@LukasReschke, thanks for your PR! By analyzing the history of the files in this pull request, we identified @icewind1991, @MorrisJobke and @bartv2 to be potential reviewers. |
Member
|
Can we have a test for the background job that covers this? |
Member
Author
Sure… Just needs somebody do it 😉 I may do that later, but likely not this week… So any volunteers are welcome. :) |
|
Tried this solution and is working fine with a lot of external mounts...... |
* Properly expire ext storage versions System-wide external storages have no real owner so the current user is used as owner. However when running cron.php there is no current user, so no expiry can be done. This fix adds an user argument to the expire() function to tell for which user to expire files. This information is anyway always available now through the expire command job. * Move version expire setupFS into the expire function * Add comment about not tearing down in version Storage::expire() Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
MorrisJobke
force-pushed
the
ext-storage-expireversions
branch
from
March 10, 2017 21:58
4592d35 to
5dbb32f
Compare
Member
|
I rebased to have this tested against latest master |
Member
|
@MorrisJobke tests seem ok! |
Member
|
Expiry still works 👍 |
MorrisJobke
approved these changes
Mar 17, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
System-wide external storages have no real owner so the current user is
used as owner. However when running cron.php there is no current user,
so no expiry can be done.
This fix adds an user argument to the expire() function to tell for
which user to expire files. This information is anyway always available
now through the expire command job.
Move version expire setupFS into the expire function
Add comment about not tearing down in version Storage::expire()
From owncloud/core#26601