Poc doctrine migrations#2827
Conversation
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
|
@LukasReschke, thanks for your PR! By analyzing the history of the files in this pull request, we identified @nickvergessen, @bartv2 and @georgehrke to be potential reviewers. |
|
|
||
| /** | ||
| * @param \OCP\IConfig $config | ||
| */ |
There was a problem hiding this comment.
PHPDoc should be adjusted.
|
|
||
| /** | ||
| * @param \OCP\IConfig $config | ||
| */ |
There was a problem hiding this comment.
PHPDoc should be adjusted
|
|
||
| /** | ||
| * @param \OCP\IConfig $config | ||
| */ |
There was a problem hiding this comment.
PHPDoc should be adjusted
|
|
||
| /** | ||
| * @param \OCP\IConfig $config | ||
| */ |
There was a problem hiding this comment.
PHPDoc should be adjusted
| */ | ||
| public function loadSchemaFromFile($file) { | ||
| $schema = new \Doctrine\DBAL\Schema\Schema(); | ||
| public function loadSchemaFromFile($file, $schema = null) { |
There was a problem hiding this comment.
$schema is not in PHPDoc
| <<<<<<< HEAD | ||
| use OC\AllConfig; | ||
| use OC\DB\ConnectionFactory; | ||
| ======= |
A bool is not always a bool... Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
5ca9b00 to
545b5d2
Compare
| * @param \OCP\IConfig $config | ||
| */ | ||
| public function __construct(IConfig $config, Connection $connection) { | ||
| $this->config = $config; |
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
|
Also there is owncloud/activity#546 which uses this approach. FYI @nickvergessen |
Current coverage is 53.50% (diff: 22.00%)@@ master #2827 diff @@
==========================================
Files 1298 1308 +10
Lines 80337 80666 +329
Methods 7957 8021 +64
Messages 0 0
Branches 1242 1242
==========================================
+ Hits 42996 43164 +168
- Misses 37341 37502 +161
Partials 0 0
|
Yep :) I would say we should test this with a first real world example for those migrations and get this in as fast as possible. Then do all our migrations with this tool. |
MorrisJobke
left a comment
MorrisJobke
left a comment
There was a problem hiding this comment.
Looks good so far - 3rdparty needs to be fixed
|
Closing this as upstream went with another approach and we should reconsider on how we want to proceed here. We can reopen at any time anyhow… |
I would like to go the doctrine migrations approach. |
5 participants
From owncloud/core#14851 – needs extensive testing …
Requires nextcloud/3rdparty#24