Skip to content

Add isDeleted to OCP\Calendar\ICalendar#34378

Merged
blizzz merged 1 commit into
masterfrom
add-isDeleted-to-icalendar
Oct 4, 2022
Merged

Add isDeleted to OCP\Calendar\ICalendar#34378
blizzz merged 1 commit into
masterfrom
add-isDeleted-to-icalendar

Conversation

@tcitworld

@tcitworld tcitworld commented Oct 2, 2022 •
edited by ChristophWurst
Loading

Copy link
Copy Markdown
Member

The DAV calendar provider can return instances of deleted calendars, which can be acceptable, but let's provide a way for users of the public API to know that they might not want to use them.

@tcitworld tcitworld added 3. to review Waiting for reviews feature: dav php Pull requests that update Php code feature: caldav Related to CalDAV internals labels Oct 2, 2022
@tcitworld tcitworld added this to the Nextcloud 26 milestone Oct 2, 2022
@tcitworld tcitworld requested a review from a team October 2, 2022 10:50
@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Oct 2, 2022
miaulalala
miaulalala approved these changes Oct 2, 2022
View reviewed changes

@miaulalala miaulalala left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one

@tcitworld

tcitworld commented Oct 2, 2022

Copy link
Copy Markdown
Member Author

Actually there's a better way of implementing this using the isDeleted() method of OCA\DAV\CalDAV\Calendar.

@tcitworld tcitworld disabled auto-merge October 2, 2022 13:58
@tcitworld tcitworld added 3. to review Waiting for reviews 2. developing Work in progress and removed 4. to release Ready to be released and/or waiting for tests to finish 3. to review Waiting for reviews labels Oct 2, 2022
@tcitworld tcitworld force-pushed the add-isDeleted-to-icalendar branch from 88aab4e to befccf0 Compare October 2, 2022 14:13
@tcitworld tcitworld added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Oct 2, 2022
@blizzz blizzz added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Oct 2, 2022
@miaulalala

miaulalala commented Oct 3, 2022

Copy link
Copy Markdown
Contributor

Conflicts with ICalendar

@tcitworld
Add isDeleted property to OCP\Calendar\ICalendar
d084e76 
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
@tcitworld tcitworld force-pushed the add-isDeleted-to-icalendar branch from befccf0 to d084e76 Compare October 3, 2022 16:56
@tcitworld

tcitworld commented Oct 3, 2022

Copy link
Copy Markdown
Member Author

Rebased

@blizzz blizzz merged commit 23df942 into master Oct 4, 2022
@blizzz blizzz deleted the add-isDeleted-to-icalendar branch October 4, 2022 13:37
@ChristophWurst ChristophWurst mentioned this pull request Oct 24, 2022
Open
@ChristophWurst ChristophWurst added the pending documentation This pull request needs an associated documentation update label Oct 24, 2022
@DaphneMuller

DaphneMuller commented Feb 21, 2023

Copy link
Copy Markdown
Contributor

hello @tcitworld ,
Thank you for your work on this pull request! This ticket seems to have the tag 'missing documentation', is there any chance you could clarify what documentation is missing? Is this for admins or for app developers?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes
@blizzz blizzz blizzz approved these changes
@miaulalala miaulalala miaulalala approved these changes
@come-nc come-nc come-nc approved these changes

Assignees

No one assigned

Labels

4. to release Ready to be released and/or waiting for tests to finish feature: caldav Related to CalDAV internals feature: dav pending documentation This pull request needs an associated documentation update php Pull requests that update Php code

Projects

None yet

Milestone

Nextcloud 26

Development

Successfully merging this pull request may close these issues.

7 participants

@tcitworld @miaulalala @DaphneMuller @ChristophWurst @blizzz @come-nc @tobiasKaminsky