Skip to content

Popovermenu files css fix#3485

Merged
blizzz merged 1 commit into
masterfrom
Popovermenu-files-css-fix
Feb 15, 2017
Merged

Popovermenu files css fix#3485
blizzz merged 1 commit into
masterfrom
Popovermenu-files-css-fix

Conversation

@skjnldsv

Copy link
Copy Markdown
Member

from
screen shot 2017-02-14 at 22 44 28
to
capture d ecran_2017-02-15_00-06-39

@skjnldsv skjnldsv added the 3. to review Waiting for reviews label Feb 14, 2017
@skjnldsv skjnldsv self-assigned this Feb 14, 2017
@mention-bot

Copy link
Copy Markdown

@skjnldsv, thanks for your PR! By analyzing the history of the files in this pull request, we identified @jancborchardt, @MorrisJobke and @butonic to be potential reviewers.

@skjnldsv skjnldsv force-pushed the Popovermenu-files-css-fix branch from 7f6f4d7 to f959eff Compare February 14, 2017 23:09
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv skjnldsv force-pushed the Popovermenu-files-css-fix branch from f959eff to 31d5615 Compare February 14, 2017 23:09
@skjnldsv skjnldsv added this to the Nextcloud 12.0 milestone Feb 14, 2017
@codecov-io

Copy link
Copy Markdown

Codecov Report

Merging #3485 into master will increase coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #3485      +/-   ##
============================================
+ Coverage     54.14%   54.15%   +0.01%     
- Complexity    21020    21182     +162     
============================================
  Files          1306     1306              
  Lines         80246    81085     +839     
  Branches       1250     1300      +50     
============================================
+ Hits          43447    43911     +464     
- Misses        36799    37174     +375
Impacted Files Coverage Δ Complexity Δ
lib/private/legacy/template.php 43.19% <ø> (-1.52%) 59% <ø> (+24%)
settings/personal.php 0% <ø> (ø) 0% <ø> (ø)
settings/users.php 0% <ø> (ø) 0% <ø> (ø)
lib/private/TemplateLayout.php 0% <ø> (ø) 39% <ø> (+7%)
settings/templates/personal.php 0% <ø> (ø) 0% <ø> (ø)
settings/templates/users/part.userlist.php 0% <ø> (ø) 0% <ø> (ø)
core/templates/layout.user.php 0% <ø> (ø) 0% <ø> (ø)
config/config.sample.php 0% <ø> (ø) 0% <ø> (ø)
core/js/sharedialogresharerinfoview.js 96.29% <ø> (+2.54%) 0% <ø> (ø)
lib/private/Files/Storage/Common.php 73.73% <ø> (+4.88%) 200% <ø> (+55%)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f74858...31d5615. Read the comment docs.

@LukasReschke LukasReschke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should get into 11 as well then :)

@blizzz blizzz merged commit cd49eb3 into master Feb 15, 2017
@blizzz blizzz deleted the Popovermenu-files-css-fix branch February 15, 2017 11:33
@blizzz

blizzz commented Feb 15, 2017

Copy link
Copy Markdown
Member

@skjnldsv just, event if it is such a small change, please use more descriptive commit messages in future 😎

@MorrisJobke

Copy link
Copy Markdown
Member

@blizzz always remove the backport-request label once you opened the backport pr - this helps to see which prs still need the backport ;)

@skjnldsv

Copy link
Copy Markdown
Member Author

@blizzz 😊

@blizzz

blizzz commented Feb 15, 2017

Copy link
Copy Markdown
Member

@MorrisJobke Scusi! 😖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews design Design, UI, UX, etc. regression

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants