Conversation
|
@schiessle, thanks for your PR! By analyzing the history of the files in this pull request, we identified @LukasReschke, @rullzer and @bartv2 to be potential reviewers. |
LukasReschke
requested changes
Feb 16, 2017
| } | ||
|
|
||
| /** | ||
| * @NoCSRFRequired |
Member
Author
There was a problem hiding this comment.
oh, left over from testing...
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
Member
Author
|
Looked at the source code of the client and saw that it doesn't use the server to send the link by mail, instead it just opens the desktop mail client with the link |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Providing a endpoint for the old API to send a public link by mail. In our case we will create a full featured mail share.
I tested it by repeating the API call with Curl, but would be good to test it with the actual sync client to make sure that's really the end point they use.
@rullzer can you test this with the upcoming sync client to see if it works as expected.