Deferred script loading#3656
Conversation
|
@michaelletzgus, thanks for your PR! By analyzing the history of the files in this pull request, we identified @nickvergessen, @LukasReschke and @ChristophWurst to be potential reviewers. |
|
I would recommend to squash these commits into a single one. 😉 |
LukasReschke
left a comment
LukasReschke
left a comment
There was a problem hiding this comment.
Before we merge that I'd love to have some official feedback from Mozilla here: https://bugzilla.mozilla.org/show_bug.cgi?id=1342781
|
@jancborchardt @jospoortvliet Knowing any Mozilla people? 😉 |
|
@benediktg |
|
(slightly off-topic)
You can squash the latest 4 commits in the current branch by doing git rebase -i HEAD~4
# replace the lower 3 occurences of 'pick' by 's'
git commit --amend -s
git push --force-with-leasein the branch of you own fork. Otherwise also the project maintainers could squash the commits at merging. |
michaelletzgus
force-pushed
the
deferred-script-loading
branch
from
eafb0f2 to
f518eeb
Compare
|
Done |
Add the 'defer' attribute to external script requests. Warning 1: This is only OK when the whole page is using 'defer', otherwise script execution order might be wrong! Warning 2: IE<=9 does not support 'defer' properly! Deferred script loading * Added 'defer' to jsfile loading * Moved inline js loading down for not interrupting deferred css and js loading
michaelletzgus
force-pushed
the
deferred-script-loading
branch
from
f518eeb to
fcc2fc8
Compare
Fork update
|
Please see PR #3696 |
4 participants
Discussed here: #2272