Skip to content

Improve oauth2 database migration from ownCloud #38577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
julien-nc merged 2 commits into from
Jun 6, 2023
Merged

Improve oauth2 database migration from ownCloud #38577

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b2a75fc
drop the oauth2_clients trusted column, delete unsupported clients an…
julien-nc Jun 1, 2023
633e951
shorten oauth2 client names before resizing the column
julien-nc Jun 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
shorten oauth2 client names before resizing the column 
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
  • Loading branch information
@julien-nc
julien-nc committed Jun 6, 2023
commit 633e9513e2a98f5271ed6a58f771334c53184c50
21 changes: 21 additions & 0 deletions lib/private/Repair/Owncloud/MigrateOauthTables.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,27 @@ public function run(IOutput $output) {
$schema = new SchemaWrapper($this->db);
$table = $schema->getTable('oauth2_clients');
if ($table->getColumn('name')->getLength() !== 64) {
// shorten existing values before resizing the column
$qb = $this->db->getQueryBuilder();
$qb->update('oauth2_clients')
->set('name', $qb->createParameter('shortenedName'))
->where($qb->expr()->eq('id', $qb->createParameter('theId')));

$qbSelect = $this->db->getQueryBuilder();
$qbSelect->select('id', 'name')
->from('oauth2_clients');

$result = $qbSelect->executeQuery();
while ($row = $result->fetch()) {
$id = $row['id'];
$shortenedName = mb_substr($row['name'], 0, 64);
$qb->setParameter('theId', $id, IQueryBuilder::PARAM_INT);
$qb->setParameter('shortenedName', $shortenedName, IQueryBuilder::PARAM_STR);
$qb->executeStatement();
}
$result->closeCursor();

// safely set the new column length
$table->getColumn('name')->setLength(64);
}
if ($table->hasColumn('allow_subdomains')) {
Expand Down