Optimize registerMounts by removing unused function #3944
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
|
@MorrisJobke, thanks for your PR! By analyzing the history of the files in this pull request, we identified @icewind1991, @nickvergessen and @LukasReschke to be potential reviewers. |
MorrisJobke
requested review from
LukasReschke,
icewind1991,
nickvergessen and
rullzer
ChristophWurst
approved these changes
Mar 20, 2017
nickvergessen
approved these changes
Mar 20, 2017
Member
Author
|
The unit test is fixed with #2847 🙈 |
MorrisJobke
added
2. developing
Member
Author
|
Moved to #2847 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@icewind1991 Seems to be code that is only used for unit test stuff -> so better make the unit tests better (if they are not already 😉 )