Skip to content

Conversation

@come-nc
Copy link
Contributor

@come-nc come-nc commented Aug 10, 2023

Summary

Test PHP 8.3 in our CI to see current support.

TODO

@come-nc come-nc added 2. developing Work in progress tests Related to tests labels Aug 10, 2023
@come-nc come-nc self-assigned this Aug 10, 2023
@come-nc
Copy link
Contributor Author

come-nc commented Aug 10, 2023

Opened shivammathur/setup-php#757

@come-nc
Copy link
Contributor Author

come-nc commented Aug 10, 2023

php-oci pipeline is passing on 8.3.
It does not run the full pipeline though.

@kesselb
Copy link
Contributor

kesselb commented Aug 11, 2023

Nice 🥳

I migrated the nodb tests last week and documented my findings: #39734

@come-nc
Copy link
Contributor Author

come-nc commented Aug 14, 2023

From https://wiki.php.net/rfc/datetime-exceptions :

The “Epoch doesn't fit in a PHP integer” now returns a new DateRangeError instead of a generic ValueError, which it does not subclass. This is only an issue for 32-bit platforms.

This is breaking the 32bit test suite.

@come-nc
Copy link
Contributor Author

come-nc commented Aug 14, 2023

Ouch, deprecation warnings were not failing in 32bit CI, activated them:

There were 173 errors:
There were 14 failures:

@come-nc come-nc force-pushed the enh/support-php-8.3 branch from 751412b to faf3a00 Compare August 14, 2023 15:04
@come-nc
Copy link
Contributor Author

come-nc commented Aug 14, 2023

There were 2 errors:
There were 18 failures:

@come-nc
Copy link
Contributor Author

come-nc commented Aug 14, 2023

Opened phpseclib/phpseclib#1931

@come-nc come-nc closed this Aug 14, 2023
@come-nc come-nc reopened this Aug 14, 2023
@come-nc come-nc force-pushed the enh/support-php-8.3 branch from 9bf0360 to 16a0a49 Compare August 14, 2023 16:12
@come-nc come-nc force-pushed the enh/support-php-8.3 branch from 16a0a49 to cd471bd Compare August 28, 2023 13:47
@come-nc come-nc force-pushed the enh/support-php-8.3 branch from 4ceef01 to 96d8e36 Compare September 25, 2023 09:02
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc come-nc force-pushed the enh/support-php-8.3 branch from 96d8e36 to fe90e32 Compare September 25, 2023 09:03
@come-nc
Copy link
Contributor Author

come-nc commented Sep 25, 2023

CI is green for 32bits on 8.3 🎉
#39734 would help adding 8.3 testing on 64bit as well.

I will make a separate PR to allow 8.3 in the version check and add it to some CI.

@come-nc come-nc mentioned this pull request Sep 26, 2023
4 tasks
@come-nc
Copy link
Contributor Author

come-nc commented Sep 26, 2023

Replaced by #40630 now that CI passes.

@come-nc come-nc closed this Sep 26, 2023
@skjnldsv skjnldsv deleted the enh/support-php-8.3 branch March 14, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2. developing Work in progress tests Related to tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support PHP 8.3

3 participants