Skip to content

fix(updatenotification): Skip update check #39806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nickvergessen merged 2 commits into from
Aug 11, 2023
Merged

fix(updatenotification): Skip update check #39806

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b63dbae
fix(updatenotification): Skip update check
Pytal Aug 11, 2023
de4bc44
test(updatenotification): No internet
Pytal Aug 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
test(updatenotification): No internet 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
  • Loading branch information
@Pytal
Pytal committed Aug 11, 2023
commit de4bc44f956cf51bcd01fa3ac01fc8824dc05eda
29 changes: 27 additions & 2 deletions apps/updatenotification/tests/Notification/BackgroundJobTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,9 +112,34 @@ public function testRun() {
$job->expects($this->once())
->method('checkAppUpdates');

$this->config->expects($this->exactly(2))
->method('getSystemValueBool')
->withConsecutive(
['has_internet_connection', true],
['debug', false],
)
->willReturnOnConsecutiveCalls(
true,
true,
);

self::invokePrivate($job, 'run', [null]);
}

public function testRunNoInternet() {
$job = $this->getJob([
'checkCoreUpdate',
'checkAppUpdates',
]);

$job->expects($this->never())
->method('checkCoreUpdate');
$job->expects($this->never())
->method('checkAppUpdates');

$this->config->method('getSystemValueBool')
->with('debug', false)
->willReturn(true);
->with('has_internet_connection', true)
->willReturn(false);

self::invokePrivate($job, 'run', [null]);
}
Expand Down