Skip to content

Merge login JS#4044

Merged
MorrisJobke merged 1 commit into
masterfrom
merge-login-js
Mar 24, 2017
Merged

Merge login JS#4044
MorrisJobke merged 1 commit into
masterfrom
merge-login-js

Conversation

@LukasReschke

Copy link
Copy Markdown
Member

Removes 2 requests. Follow-up for #3988

Signed-off-by: Lukas Reschke lukas@statuscode.ch

Removes 2 requests.

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
@LukasReschke LukasReschke added the 3. to review Waiting for reviews label Mar 24, 2017
@LukasReschke LukasReschke added this to the Nextcloud 12.0 milestone Mar 24, 2017
@mention-bot

Copy link
Copy Markdown

@LukasReschke, thanks for your PR! By analyzing the history of the files in this pull request, we identified @jancborchardt, @blizzz and @ChristophWurst to be potential reviewers.

@LukasReschke LukasReschke mentioned this pull request Mar 24, 2017
3 tasks
@codecov-io

codecov-io commented Mar 24, 2017

Copy link
Copy Markdown

Codecov Report

Merging #4044 into master will increase coverage by <.01%.
The diff coverage is 0%.

@@             Coverage Diff              @@
##             master    #4044      +/-   ##
============================================
+ Coverage     54.24%   54.24%   +<.01%     
  Complexity    21272    21272              
============================================
  Files          1310     1310              
  Lines         81164    81160       -4     
  Branches       1284     1284              
============================================
- Hits          44028    44027       -1     
+ Misses        37136    37133       -3
Impacted Files Coverage Δ Complexity Δ
core/templates/login.php 0% <0%> (ø) 0 <0> (ø) ⬇️
apps/files_trashbin/lib/Trashbin.php 73.39% <0%> (-0.25%) 133% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f73911...6a4fde1. Read the comment docs.

@MorrisJobke MorrisJobke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@MorrisJobke MorrisJobke merged commit 8aedebf into master Mar 24, 2017
@MorrisJobke MorrisJobke deleted the merge-login-js branch March 24, 2017 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants