Skip to content

Allow PHP 8.3 #40630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kesselb merged 5 commits into from
Sep 30, 2023
Merged

Allow PHP 8.3 #40630

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1daa881
Allow PHP 8.3 in version check
come-nc Aug 10, 2023
796bf32
Adding ini-file:development to 32bit CI
come-nc Aug 14, 2023
e20ba1c
Add 8.3 to lint CI and 32bits test suite
come-nc Sep 26, 2023
5586f2d
Use latest shivammathur/setup-php in phpunit-32bits.yml
come-nc Sep 26, 2023
7e0ed6b
ci: clear disable_functions to enable pcntl_signal
kesselb Sep 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/lint-php.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
php-versions: [ "8.0", "8.1", "8.2" ]
php-versions: [ "8.0", "8.1", "8.2", "8.3" ]

name: php-lint

Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/phpunit-32bits.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ jobs:

strategy:
matrix:
php-versions: ['8.0']
php-versions: ['8.0','8.3']

steps:
- name: Checkout server
Expand All @@ -40,15 +40,15 @@ jobs:
sudo apt-get install -y ffmpeg imagemagick libmagickcore-6.q16-3-extra

- name: Set up php ${{ matrix.php-versions }}
uses: shivammathur/setup-php@9c77701ae57b0c47f6732beebfbdec76e4e5c90a #debian bookworm fix
uses: shivammathur/setup-php@72ae4ccbe57f82bbe08411e84e2130bd4ba1c10f #v2.25.5
with:
php-version: ${{ matrix.php-versions }}
extensions: ctype, curl, dom, fileinfo, gd, imagick, intl, json, mbstring, openssl, pdo_sqlite, posix, sqlite, xml, zip, apcu
tools: phpunit:9
coverage: none
ini-file: development
ini-values:
apc.enabled=on,
apc.enable_cli=on
apc.enabled=on, apc.enable_cli=on, disable_functions= # https://github.com/shivammathur/setup-php/discussions/573
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

Expand Down
6 changes: 3 additions & 3 deletions lib/versioncheck.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,10 @@
exit(1);
}

// Show warning if >= PHP 8.3 is used as Nextcloud is not compatible with >= PHP 8.3 for now
if (PHP_VERSION_ID >= 80300) {
// Show warning if >= PHP 8.4 is used as Nextcloud is not compatible with >= PHP 8.4 for now
if (PHP_VERSION_ID >= 80400) {
http_response_code(500);
echo 'This version of Nextcloud is not compatible with PHP>=8.3.<br/>';
echo 'This version of Nextcloud is not compatible with PHP>=8.4.<br/>';
echo 'You are currently running ' . PHP_VERSION . '.';
exit(1);
}