Skip to content

Update strengthify and fix password strength#4083

Merged
MorrisJobke merged 1 commit into
masterfrom
update-strengthify
Mar 27, 2017
Merged

Update strengthify and fix password strength#4083
MorrisJobke merged 1 commit into
masterfrom
update-strengthify

Conversation

@MorrisJobke

Copy link
Copy Markdown
Member

@MorrisJobke MorrisJobke added the 3. to review Waiting for reviews label Mar 26, 2017
@MorrisJobke MorrisJobke added this to the Nextcloud 12.0 milestone Mar 26, 2017
@mention-bot

Copy link
Copy Markdown

@MorrisJobke, thanks for your PR! By analyzing the history of the files in this pull request, we identified @rullzer, @nickvergessen and @ChristophWurst to be potential reviewers.

@codecov-io

codecov-io commented Mar 26, 2017

Copy link
Copy Markdown

Codecov Report

Merging #4083 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #4083      +/-   ##
============================================
- Coverage     54.24%   54.24%   -0.01%     
  Complexity    21285    21285              
============================================
  Files          1310     1310              
  Lines         81187    81189       +2     
  Branches       1284     1284              
============================================
- Hits          44038    44037       -1     
- Misses        37149    37152       +3
Impacted Files Coverage Δ Complexity Δ
lib/private/Files/Cache/Propagator.php 94.93% <0%> (-1.27%) 16% <0%> (ø)
core/js/js.js 62.17% <0%> (-0.15%) 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ba114d...e254aa4. Read the comment docs.

@rullzer rullzer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work

@rullzer

rullzer commented Mar 27, 2017

Copy link
Copy Markdown
Member

Ah conflicts!

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@MorrisJobke

Copy link
Copy Markdown
Member Author

Ah conflicts!

Fixed - was only in the gitignore of core/vendor

@MorrisJobke MorrisJobke merged commit 56243e0 into master Mar 27, 2017
@MorrisJobke MorrisJobke deleted the update-strengthify branch March 27, 2017 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

jQuery.globalEval()={} - Problem with password strength and files_markdown

5 participants