[11] Prevent PHP request to get killed when using fclose callback (#26775)#4491
Merged
Conversation
* Prevent PHP request to get killed when using fclose callback * Add ignore_user_abort everywhere where the time limit is set to 0 Signed-off-by: Robin Appelman <robin@icewind.nl>
|
@icewind1991, thanks for your PR! By analyzing the history of the files in this pull request, we identified @LukasReschke, @nickvergessen and @schiessle to be potential reviewers. |
Codecov Report
@@ Coverage Diff @@
## stable11 #4491 +/- ##
=============================================
- Coverage 57.46% 57.4% -0.06%
Complexity 19441 19441
=============================================
Files 1157 1214 +57
Lines 65750 72573 +6823
Branches 0 1237 +1237
=============================================
+ Hits 37782 41660 +3878
- Misses 27968 30913 +2945
|
blizzz
approved these changes
Apr 25, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #3157
Prevent PHP request to get killed when using fclose callback
Add ignore_user_abort everywhere where the time limit is set to 0