Keep file id on move - #4524
Merged
Merged
Conversation
This removes the duplicated code
Sabre usually deletes the target node on MOVE before proceeding with the actual move operation. This fix prevents this to happen in case the source node is a FutureFile.
|
@nickvergessen, thanks for your PR! By analyzing the history of the files in this pull request, we identified @icewind1991, @SergioBertolinSG and @rullzer to be potential reviewers. |
Member
|
CI is not happy 😞 |
Codecov Report
@@ Coverage Diff @@
## master #4524 +/- ##
=============================================
- Coverage 54.26% 31.39% -22.88%
- Complexity 21897 21898 +1
=============================================
Files 1348 1348
Lines 83971 83383 -588
Branches 1334 1334
=============================================
- Hits 45564 26175 -19389
- Misses 38407 57208 +18801
|
Member
Fixed by renaming the copied class 🙈 |
MorrisJobke
approved these changes
Apr 27, 2017
MorrisJobke
left a comment
MorrisJobke
left a comment
Member
There was a problem hiding this comment.
Tested and works 👍 Also fixes #4284
MorrisJobke
added
4. to release
Member
@rullzer @icewind1991 @nickvergessen Can one of you look into this? |
MorrisJobke
added
2. developing
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
force-pushed
the
downstream-27508
branch
from
April 27, 2017 07:54
dd92f4b to
20c7975
Compare
Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
force-pushed
the
downstream-27508
branch
from
April 27, 2017 08:18
20c7975 to
a9d06c0
Compare
Member
|
@nickvergessen Unit Tests are still failing |
Signed-off-by: Joas Schilling <coding@schilljs.com>
MorrisJobke
added
4. to release
Member
|
@nickvergessen Backport? |
Member
Author
|
Don't really feel like backporting a 800 lines patch like this to 11.... |
nickvergessen
commented
May 26, 2017
| if ($node instanceof \OCA\DAV\Connector\Sabre\Node) { | ||
| if (!$node->getFileInfo()->isReadable()) { | ||
| // avoid detecting files through this means | ||
| throw new NotFound(); |
Member
Author
There was a problem hiding this comment.
Regression, this breaks dir listing for folders which have an item blocked by files access control:
nextcloud/files_accesscontrol#65
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Downstream 27508