Skip to content

fix(files): Use data-cy (data attribute) instead of cy-data #45789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
skjnldsv merged 2 commits into from
Jun 12, 2024
Merged

fix(files): Use data-cy (data attribute) instead of cy-data #45789

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7f3cc75
fix(files): Use `data-cy` (data attribute) instead of `cy-data`
susnux Jun 11, 2024
fea5c22
chore: Compile assets
susnux Jun 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix(files): Use data-cy (data attribute) instead of cy-data 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
  • Loading branch information
@susnux
susnux committed Jun 11, 2024
commit 7f3cc7502ba81174671ee87dda58f9275bdde4e0
2 changes: 1 addition & 1 deletion apps/files/src/views/Sidebar.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<template>
<NcAppSidebar v-if="file"
ref="sidebar"
cy-data-sidebar
data-cy-sidebar
v-bind="appSidebar"
:force-menu="true"
@close="close"
Expand Down
2 changes: 1 addition & 1 deletion cypress/e2e/files/FilesUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ export const navigateToFolder = (dirPath: string) => {

export const closeSidebar = () => {
// {force: true} as it might be hidden behind toasts
cy.get('[cy-data-sidebar] .app-sidebar__close').click({ force: true })
cy.get('[data-cy-sidebar] .app-sidebar__close').click({ force: true })
}

export const clickOnBreadcrumbs = (label: string) => {
Expand Down
12 changes: 6 additions & 6 deletions cypress/e2e/files/files-sidebar.cy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ describe('Files: Sidebar', { testIsolation: true }, () => {

triggerActionForFile('file', 'details')

cy.get('[cy-data-sidebar]').should('be.visible')
cy.get('[data-cy-sidebar]').should('be.visible')
})

it('changes the current fileid', () => {
Expand All @@ -35,7 +35,7 @@ describe('Files: Sidebar', { testIsolation: true }, () => {

triggerActionForFile('file', 'details')

cy.get('[cy-data-sidebar]').should('be.visible')
cy.get('[data-cy-sidebar]').should('be.visible')
cy.url().should('contain', `apps/files/files/${fileId}`)
})

Expand All @@ -46,10 +46,10 @@ describe('Files: Sidebar', { testIsolation: true }, () => {
// open the sidebar
triggerActionForFile('file', 'details')
// validate it is open
cy.get('[cy-data-sidebar]').should('be.visible')
cy.get('[data-cy-sidebar]').should('be.visible')

triggerActionForFile('file', 'delete')
cy.get('[cy-data-sidebar]').should('not.exist')
cy.get('[data-cy-sidebar]').should('not.exist')
})

it('changes the fileid on delete', () => {
Expand All @@ -65,11 +65,11 @@ describe('Files: Sidebar', { testIsolation: true }, () => {
// open the sidebar
triggerActionForFile('other', 'details')
// validate it is open
cy.get('[cy-data-sidebar]').should('be.visible')
cy.get('[data-cy-sidebar]').should('be.visible')
cy.url().should('contain', `apps/files/files/${otherFileId}`)

triggerActionForFile('other', 'delete')
cy.get('[cy-data-sidebar]').should('not.exist')
cy.get('[data-cy-sidebar]').should('not.exist')
// Ensure the URL is changed
cy.url().should('not.contain', `apps/files/files/${otherFileId}`)
})
Expand Down