Skip to content

Match input height with clickable area #46270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marcoambrosini merged 1 commit into from
Jul 3, 2024
Merged

Match input height with clickable area #46270

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions core/css/inputs.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ input, textarea, select, button, div[contenteditable=true], div[contenteditable=
background-image: unset !important;
}

$default-height: 36px;
$opacity-disabled: .7;

/* Simple selector to allow easy overriding */
Expand All @@ -32,7 +31,7 @@ textarea,
div[contenteditable=true],
div[contenteditable=false] {
width: 130px;
min-height: $default-height;
min-height: var(--default-clickable-area);
box-sizing: border-box;
}

Expand Down Expand Up @@ -175,7 +174,7 @@ input {
-moz-appearance: textfield;
appearance: textfield;
// force height for inline elements like inputs (not textarea, contenteditable...)
height: $default-height;
height: var(--default-clickable-area);
}
&[type='radio'],
&[type='checkbox'],
Expand Down Expand Up @@ -215,7 +214,7 @@ input[type='reset'] {
padding: 8px 14px;
font-size: var(--default-font-size);
width: auto;
min-height: $default-height;
min-height: var(--default-clickable-area);
cursor: pointer;
box-sizing: border-box;
background-color: var(--color-background-dark);
Expand Down Expand Up @@ -352,8 +351,8 @@ input {
/* Avoid background under border */
background-color: var(--color-main-background) !important;
opacity: 1;
height: $default-height;
width: $default-height;
height: var(--default-clickable-area);
width: var(--default-clickable-area);
padding: 7px 6px;
cursor: pointer;
margin-right: 0;
Expand Down