Skip to content

use the same logo css for the error page as the login page#4771

Merged
nickvergessen merged 1 commit into
masterfrom
error-page-logo-css
May 10, 2017
Merged

use the same logo css for the error page as the login page#4771
nickvergessen merged 1 commit into
masterfrom
error-page-logo-css

Conversation

@icewind1991

Copy link
Copy Markdown
Member

Fixes themed logo not being displayed correctly on the error page

Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991 icewind1991 added the 3. to review Waiting for reviews label May 9, 2017
@icewind1991 icewind1991 added this to the Nextcloud 12.0 milestone May 9, 2017
@mention-bot

Copy link
Copy Markdown

@icewind1991, thanks for your PR! By analyzing the history of the files in this pull request, we identified @skjnldsv, @juliushaertl and @jancborchardt to be potential reviewers.

@codecov

codecov Bot commented May 9, 2017

Copy link
Copy Markdown

Codecov Report

Merging #4771 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #4771   +/-   ##
=========================================
  Coverage     54.22%   54.22%           
  Complexity    22137    22137           
=========================================
  Files          1363     1363           
  Lines         84806    84806           
  Branches       1322     1322           
=========================================
  Hits          45989    45989           
  Misses        38817    38817
Impacted Files Coverage Δ Complexity Δ
lib/private/Server.php 93.37% <0%> (-0.15%) 120% <0%> (ø)
lib/private/Security/CertificateManager.php 91.83% <0%> (+1.02%) 39% <0%> (ø) ⬇️

@MorrisJobke MorrisJobke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@MorrisJobke

Copy link
Copy Markdown
Member

Error page: http://example.org/s/qwertzuiop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants