Skip to content

[stable30] fix: promote re-shares when deleting the parent share #49629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
luka-nextcloud merged 10 commits into from
Dec 19, 2024
Merged

[stable30] fix: promote re-shares when deleting the parent share #49629

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
024f98a
fix: delete re-shares when deleting the parent share
luka-nextcloud Aug 7, 2024
16decde
fix: Tidy up code for reshare deletion
come-nc Aug 22, 2024
f0e10ea
fix: Transfer incomming shares first, do not delete non-migratable ones
come-nc Aug 26, 2024
c7dbe7e
fix(shares): Promote reshares into direct shares when share is deleted
come-nc Sep 13, 2024
04b6eef
chore: Turn method description into phpdoc
come-nc Sep 15, 2024
ec85a49
chore: Add comment to make code clearer
come-nc Sep 16, 2024
10c7e10
fix(tests): Fix share tests to test new reshare promotion system
come-nc Oct 3, 2024
ba76378
fix(tests): Revert changes to tests now that reshares are not deleted…
come-nc Oct 8, 2024
e30cd2f
fix: Fix promotion of reshares from subsubfolders
come-nc Oct 14, 2024
28c885d
fix: Use getRelativePath method to check if node is inside folder
come-nc Oct 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: Add comment to make code clearer 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
  • Loading branch information
@come-nc
come-nc committed Dec 19, 2024
commit ec85a49cadafda7cbcf244692374e96993ce9c66
1 change: 1 addition & 0 deletions lib/private/Share20/Manager.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1092,6 +1092,7 @@ protected function promoteReshares(IShare $share): void {

foreach ($reshareRecords as $child) {
try {
/* Check if the share is still valid (means the resharer still has access to the file through another mean) */
$this->generalCreateChecks($child);
} catch (GenericShareException $e) {
/* The check is invalid, promote it to a direct share from the sharer of parent share */
Expand Down