Skip to content

[stable32] Fix chunked upload for file drop shares #55804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
solracsf merged 8 commits into from
Dec 2, 2025
Merged

[stable32] Fix chunked upload for file drop shares #55804

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
0320a99
fix(publicremote): Always grant read and delete permission for chunke…
provokateurin Oct 15, 2025
f4f0a1a
fix(FilesDropPlugin): Disable plugin for chunked uploads
provokateurin Oct 15, 2025
309c165
fix(FilesDropPlugin): Fix name conflict resolution for chunked uploads
provokateurin Oct 15, 2025
bcae496
fix(FilesDropPlugin): Fix request method and nickname header checks
provokateurin Oct 15, 2025
9b438cc
Revert "fix: temporarily disable public shares chunking capability"
provokateurin Nov 18, 2025
281949f
fix(FilesDropPlugin): Also modify Destination header for PUT requests…
provokateurin Nov 18, 2025
b5ad0aa
fix(FilesDropPlugin): Allow MKCOL for file drop to upload folders
provokateurin Oct 16, 2025
b737336
fix(FilesDropPlugin): Ensure all request for file request have a nick…
provokateurin Oct 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix(FilesDropPlugin): Allow MKCOL for file drop to upload folders 
Signed-off-by: provokateurin <kate@provokateurin.de>
  • Loading branch information
@provokateurin
provokateurin committed Nov 18, 2025
commit b5ad0aad3a8c506735e3d870201743cc530f6594
9 changes: 0 additions & 9 deletions apps/dav/lib/Files/Sharing/FilesDropPlugin.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,6 @@ public function beforeMethod(RequestInterface $request, ResponseInterface $respo
$rootPath = substr($path, 0, strpos($path, $token) + strlen($token));
// e.g /Folder/image.jpg
$relativePath = substr($path, strlen($rootPath));
$isRootUpload = substr_count($relativePath, '/') === 1;

// Extract the attributes for the file request
$isFileRequest = false;
Expand All @@ -132,14 +131,6 @@ public function beforeMethod(RequestInterface $request, ResponseInterface $respo
throw new BadRequest('A nickname header is required for file requests');
}

// We're only allowing the upload of
// long path with subfolders if a nickname is set.
// This prevents confusion when uploading files and help
// classify them by uploaders.
if (!$nickname && !$isRootUpload) {
throw new BadRequest('A nickname header is required when uploading subfolders');
}

if ($nickname) {
try {
$node->verifyPath($nickname);
Expand Down