LDAP Wizard: do not attempt to recognise cert issue by using LDAPTLS_REQCERT#5616
Merged
Merged
Conversation
|
@blizzz, thanks for your PR! By analyzing the history of the files in this pull request, we identified @LukasReschke, @MorrisJobke and @VicDeo to be potential reviewers. |
MorrisJobke
approved these changes
Jul 5, 2017
Codecov Report
@@ Coverage Diff @@
## master #5616 +/- ##
============================================
+ Coverage 53.82% 53.82% +<.01%
+ Complexity 22731 22726 -5
============================================
Files 1403 1403
Lines 86635 86627 -8
Branches 1328 1328
============================================
- Hits 46630 46628 -2
+ Misses 40005 39999 -6
|
first, it does not work (at least not everywhere/reliably), second if it did it was not reset properly. Removes a bit of complexity. Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
LukasReschke
force-pushed
the
ldap-wizard-remove-LDAPTLS_REQCERT-attempt
branch
from
027ff99 to
2543991
Compare
Member
|
Rebased to retrigger test execution |
Member
|
@rullzer Ping |
Member
|
@MorrisJobke well I have no idea how to test or what I'm testing :P |
Member
I would not do that. Once we have a more clear idea if it fixes that specific bug, then sure, but until we have no clear issue, I would avoid to backport. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
first, it does not work (at least not everywhere/reliably), second if it
did it was not reset properly. Removes a bit of complexity (and useless debug output).
Might be worth to backport… there is no known bug about this, but it would not be straight forward to track it hereto.
please review @nextcloud/ldap