Skip to content

feat(profile): show Teams memberships on account details #57439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
provokateurin merged 8 commits into from
Jan 19, 2026
Merged

feat(profile): show Teams memberships on account details #57439

provokateurin merged 8 commits into from
Jan 19, 2026

Conversation

@cristianscheid
Copy link
Contributor

@cristianscheid cristianscheid commented Jan 8, 2026

Summary

Adds Teams (circles) memberships to the personal account details page, providing users with a complete overview of all their group memberships. This enhances the current scenario where only group memberships from connected user backends are displayed, excluding Teams memberships.

Before

before

After

after

Checklist

@cristianscheid cristianscheid requested review from a team as code owners January 8, 2026 16:40
@cristianscheid cristianscheid added the 3. to review Waiting for reviews label Jan 8, 2026
@cristianscheid cristianscheid requested review from artonge, leftybournes, provokateurin, sorbaugh, susnux and szaimen and removed request for a team January 8, 2026 16:40
come-nc
come-nc reviewed Jan 8, 2026
View reviewed changes
Copy link
Contributor

@come-nc come-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It’s a bit sad that we have to turn Circle instances into Team instances, I wonder why Team is not an ITeam interface implemented by Circle 🤷
But I guess it’s too late to change that without breaking API.

A few remarks but looks good 👍

provokateurin
provokateurin requested changes Jan 12, 2026
View reviewed changes
@cristianscheid cristianscheid force-pushed the enh/50636/show-teams-memberships-profile branch from 5f9ff96 to 9eb1bc7 Compare January 12, 2026 12:23
susnux
susnux reviewed Jan 12, 2026
View reviewed changes
@sorbaugh sorbaugh requested a review from susnux January 15, 2026 13:11
@provokateurin
Copy link
Member

provokateurin commented Jan 19, 2026

/compile rebase

cristianscheid and others added 6 commits January 19, 2026 12:10
@cristianscheid @nextcloud-command
feat(profile): show Teams memberships on account details
5c1b795 
Signed-off-by: Cristian Scheid <cristianscheid@gmail.com>
@cristianscheid @nextcloud-command
chore: fix code style in PersonalInfo
7e1b5af 
Signed-off-by: Cristian Scheid <cristianscheid@gmail.com>
@cristianscheid @come-nc @nextcloud-command
refactor: improve code quality and doc block in PersonalInfo
a109ed3 
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Cristian Scheid <74515775+cristianscheid@users.noreply.github.com>
@cristianscheid @provokateurin @nextcloud-command
refactor: use list<> syntax and remove unecessary check
d3dd2f4 
Co-authored-by: Kate <26026535+provokateurin@users.noreply.github.com>
Signed-off-by: Cristian Scheid <74515775+cristianscheid@users.noreply.github.com>
@cristianscheid @nextcloud-command
refactor: replace array_map with foreach to guarantee list<> type
3e7d683 
Signed-off-by: Cristian Scheid <cristianscheid@gmail.com>
@cristianscheid @nextcloud-command
refactor: use probeCircles instead of getCircles
efd348f 
Signed-off-by: Cristian Scheid <cristianscheid@gmail.com>
cristianscheid and others added 2 commits January 19, 2026 12:10
@cristianscheid @nextcloud-command
refactor: change method name from getMemberships to getTeamsForUser
ed48616 
Signed-off-by: Cristian Scheid <cristianscheid@gmail.com>
@nextcloud-command
chore(assets): Recompile assets
6067f1c 
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@nextcloud-command nextcloud-command force-pushed the enh/50636/show-teams-memberships-profile branch from 0151b37 to 6067f1c Compare January 19, 2026 12:13
@provokateurin provokateurin merged commit b273338 into master Jan 19, 2026
218 of 233 checks passed
@provokateurin provokateurin deleted the enh/50636/show-teams-memberships-profile branch January 19, 2026 12:52
@nextcloud-bot nextcloud-bot mentioned this pull request Jan 20, 2026
Merged
@github-actions
Copy link
Contributor

github-actions bot commented Jan 23, 2026

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@susnux susnux susnux approved these changes

@provokateurin provokateurin provokateurin approved these changes

@sorbaugh sorbaugh sorbaugh approved these changes

@artonge artonge Awaiting requested review from artonge artonge is a code owner automatically assigned from nextcloud/server-frontend

@szaimen szaimen Awaiting requested review from szaimen szaimen is a code owner automatically assigned from nextcloud/server-frontend

@leftybournes leftybournes Awaiting requested review from leftybournes leftybournes is a code owner automatically assigned from nextcloud/server-backend

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl

@come-nc come-nc Awaiting requested review from come-nc

Assignees

No one assigned

Labels

3. to review Waiting for reviews feedback-requested

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Showing Teams memberships on personal account details page

8 participants

@cristianscheid @provokateurin @ArtificialOwl @susnux @sorbaugh @come-nc @nextcloud-command