Remove setUidAsDisplayName

[LukasReschke]

This code is a leftover from the old Shibboleth implementation from ownCloud days, nowadays it causes more issues than it does good (such as nextcloud/user_saml#137). Let's remove it for the future thus.

Signed-off-by: Lukas Reschke lukas@statuscode.ch

[codecov]

Codecov Report

Merging #5939 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #5939      +/-   ##
============================================
- Coverage     53.01%   53.01%   -0.01%     
+ Complexity    22759    22754       -5     
============================================
  Files          1404     1404              
  Lines         88061    88053       -8     
  Branches       1327     1327              
============================================
- Hits          46684    46677       -7     
+ Misses        41377    41376       -1

Impacted Files	Coverage Δ	Complexity Δ
lib/private/legacy/user.php	47.16% <ø> (+2.25%)	62 <0> (-5)	⬇️
apps/comments/lib/EventHandler.php	79.16% <0%> (-8.34%)	7% <0%> (ø)
lib/private/Files/Cache/Propagator.php	94.93% <0%> (-1.27%)	16% <0%> (ø)
core/js/js.js	61.27% <0%> (-0.56%)	0% <0%> (ø)
apps/files_trashbin/lib/Trashbin.php	72.77% <0%> (+0.24%)	136% <0%> (ø)	⬇️

[rullzer]

🐘

[MorrisJobke]

This code is a leftover from the old Shibboleth implementation from ownCloud days, nowadays it causes more issues than it does good (such as nextcloud/user_saml#137). Let's remove it for the future thus.

😕 You added it to 12 in February: #3507 🤔

[MorrisJobke]

@LukasReschke Backport to stable12?

[LukasReschke]

😕 You added it to 12 in February: #3507 🤔

Nope. In February I added an if/else statement with regard to self::setDisplayName($uid);, but this one was not sufficient and now the SAML app also handles this case properly.

No need for a backport.