[POC] Inline small svg files in css#6020
Closed
rullzer wants to merge 1 commit into
Closed
Conversation
A simple helper function for the SCSS compiler to include svg files. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Member
|
So this checks all existing url() sections in SCSS and replaces them with inline stuff if it is an SVG? How about relative paths? How about stuff inside of apps that refer to the server images? |
Member
Author
|
Yes that will fail for now... then we have to do more url magic etc. |
Closed
Contributor
|
👎 see my comment in #5985 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A simple helper function for the SCSS compiler to include svg files.