Refactor(index.php): entrypoint error handling and improve fatal fallback messaging#60362
Open
joshtrichards wants to merge 2 commits into
Open
Refactor(index.php): entrypoint error handling and improve fatal fallback messaging#60362joshtrichards wants to merge 2 commits into
joshtrichards wants to merge 2 commits into
Conversation
joshtrichards
added
2. developing
joshtrichards
changed the title
index.php entrypoing error handling and improve fatal fallback messaging
joshtrichards
added
3. to review
joshtrichards
requested review from
CarlSchwan,
artonge,
leftybournes and
provokateurin
and removed request for
a team
8 tasks
…atal fallback messaging Move the repeated LoginException/MaxDelayReached non-HTML response logic into a shared helper so the request error handling reads more consistently. Rework the inline comments to better describe the different failure tiers and distinguish expected client-side errors from server-side issues that may require admin attention. Also improve the final fatal-error plain-text fallback so it provides clearer guidance for users and administrators, including a timestamp for support correlation (all we can rely on in the last resort path) and dropping the erroneous prior inline request to "include the technical details below in your report" (there aren't any), while preserving the original error propagation. Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
joshtrichards
force-pushed
the
jtr/refactor-index-entrypoint-error-handling-and-messaging
branch
from
3cabc5d to
2c9da5c
Compare
artonge
approved these changes
May 27, 2026
artonge
reviewed
May 27, 2026
Comment on lines
+43
to
+46
| exit(); | ||
| } | ||
|
|
||
| $templateManager->printErrorPage($message, $message, $statusCode); |
Collaborator
There was a problem hiding this comment.
The exit call is new, right?
I would have thought that the following would be closer to the original.
Suggested change
| exit(); | |
| } | |
| $templateManager->printErrorPage($message, $message, $statusCode); | |
| else { | |
| $templateManager->printErrorPage($message, $message, $statusCode); | |
| } |
come-nc
added
2. developing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This changeset refactors
index.phperror handling to make the different failure paths easier to follow and more consistent.What changed
LoginExceptionandMaxDelayReachedthrow $ex;Notes
Follow-up considerations
We should consider:
Acceptheader check more robust to avoid false positives, including exact string matching as well as proper handling of quality factors (q=)TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)