Skip to content

test(ci): Do not always run e2e tests#61167

Merged
artonge merged 1 commit into
masterfrom
artonge/test/dont_always_run_e2e_tests
Jun 11, 2026
Merged

test(ci): Do not always run e2e tests#61167
artonge merged 1 commit into
masterfrom
artonge/test/dont_always_run_e2e_tests

Conversation

@artonge

@artonge artonge commented Jun 10, 2026

Copy link
Copy Markdown
Collaborator

This will run cypress and playwright only if the following conditions are met:

  1. Has one of the following labels: '3. to review', '4. to release', 'force-e2e-tests'
  2. A file path starting with 'cypress' or 'playwright' was touched

The workflow will be re-evaluated when a label is added.

  • The content of this PR was partly or fully generated using AI

@artonge
artonge requested a review from a team as a code owner June 10, 2026 15:54
@artonge
artonge requested review from Altahrim, ArtificialOwl, come-nc and icewind1991 and removed request for a team June 10, 2026 15:54
@artonge
artonge force-pushed the artonge/test/dont_always_run_e2e_tests branch 2 times, most recently from 0c513ee to e4c740a Compare June 11, 2026 07:52
@artonge artonge self-assigned this Jun 11, 2026
@artonge artonge added the CI label Jun 11, 2026
@artonge
artonge force-pushed the artonge/test/dont_always_run_e2e_tests branch 2 times, most recently from b659b07 to 42e2c35 Compare June 11, 2026 12:42
Comment thread .github/workflows/cypress.yml Outdated
Comment thread .github/workflows/playwright.yml Outdated
@artonge
artonge force-pushed the artonge/test/dont_always_run_e2e_tests branch 5 times, most recently from 6be75a9 to 05ed839 Compare June 11, 2026 15:01
@artonge artonge added 3. to review Waiting for reviews and removed 3. to review Waiting for reviews labels Jun 11, 2026
@artonge
artonge marked this pull request as draft June 11, 2026 15:04
@artonge artonge removed the 3. to review Waiting for reviews label Jun 11, 2026
@artonge
artonge force-pushed the artonge/test/dont_always_run_e2e_tests branch from 05ed839 to 67f1465 Compare June 11, 2026 15:06
@artonge
artonge marked this pull request as ready for review June 11, 2026 15:07
@artonge artonge added the 4. to release Ready to be released and/or waiting for tests to finish label Jun 11, 2026
@artonge
artonge force-pushed the artonge/test/dont_always_run_e2e_tests branch from 67f1465 to 3b970bf Compare June 11, 2026 15:12
@artonge
artonge marked this pull request as draft June 11, 2026 15:13
@artonge artonge removed the 4. to release Ready to be released and/or waiting for tests to finish label Jun 11, 2026
@artonge
artonge marked this pull request as ready for review June 11, 2026 15:15
@artonge artonge added the 3. to review Waiting for reviews label Jun 11, 2026
@artonge
artonge force-pushed the artonge/test/dont_always_run_e2e_tests branch 4 times, most recently from ffe6cee to 58dd2ef Compare June 11, 2026 15:22
@artonge artonge added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jun 11, 2026
@artonge
artonge force-pushed the artonge/test/dont_always_run_e2e_tests branch from 58dd2ef to 184866a Compare June 11, 2026 15:32

@susnux susnux left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as they still run when its not a draft thats fine :)

Signed-off-by: Louis Chmn <louis@chmn.me>
@artonge
artonge force-pushed the artonge/test/dont_always_run_e2e_tests branch from 184866a to 4a3f25d Compare June 11, 2026 15:53
@artonge
artonge merged commit d4751c6 into master Jun 11, 2026
43 of 145 checks passed
@artonge
artonge deleted the artonge/test/dont_always_run_e2e_tests branch June 11, 2026 16:12
@DerDreschner

Copy link
Copy Markdown
Contributor

Shouldn't that change being integrated into the templates as well?

steps:
- name: Evaluate e2e tests execution conditions
id: gate-e2e
uses: actions/github-script@60a0d83039c74a4aee543508d2ffcb1c3799cdea # v8.0.0

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's not version 8 being referenced. That commit belongs to version 7.0.1 from 2023.

@DerDreschner

Copy link
Copy Markdown
Contributor

Okay, the cypress.yml file has a lot of changes that are not in the template repository... Which makes changes like the buildjet deprecation a bit hard as it must be applied multiple times manually.

@susnux

susnux commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Shouldn't that change being integrated into the templates as well?

Server is special here compared to apps (what the templates are for).
So its a a more specific workflow - similar with the others (phpunit-XXX).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants