feat: contacts import ocs by SebastianKrupinski · Pull Request #61277 · nextcloud/server

SebastianKrupinski · 2026-06-13T17:47:40Z

Resolves: client feature

Summary

for: fix: import contacts#5386
added end point to import contacts

Checklist

Code is properly formatted
Sign-off message is added to all commits
Tests (unit, integration, api and/or acceptance) are included
Screenshots before/after for front-end changes
Documentation (manuals or wiki) has been updated or is not required
Backports requested where applicable (ex: critical bugfixes)
Labels added where applicable (ex: bug/enhancement, 3. to review, feature component)
Milestone added for target branch/version (ex: 32.x for stable32)

AI (if applicable)

The content of this PR was partly or fully generated using AI

ChristophWurst · 2026-06-25T05:59:59Z

+
+use JsonSerializable;
+
+interface ImportEvent extends JsonSerializable {


What value does this interface add of it has no methods?

This is a common type for ImportCountEvent and ImportObjectEvent, its used to stream events all the way to the UI while processing.

Got it. For simplicity, could you just use JsonSerializable in the few areas you use ImportEvent right now?

Hmm, I think I would prefer the current way to make it more clear what's being expected from a readability standpoint 🤔

This PR has to be backported. Can we keep it simple?

You can add the YAGNI abstraction to master. But for the backportable bit let's skip it

This PR has to be backported. Can we keep it simple?

Ahh, yeah, I didn't had that in mind. So, I'll agree with you 😄

You can add the YAGNI abstraction to master. But for the backportable bit let's skip it

I agree with this. Lets do this.

DerDreschner · 2026-07-02T13:02:16Z

+		}
+		return match ($options->getFormat()) {
+			'vcf' => $this->importProcess($source, $addressBook, $options, $this->importText(...)),
+			'jcf' => $this->importProcess($source, $addressBook, $options, $this->importJson(...)),


Json and Xml aren't implemented (I've tested that, instant crash). So, maybe makes sense to remove for now?

Ah! Forgot to remove those! Done

DerDreschner · 2026-07-02T13:10:18Z

There are still some issues 🤔 The getResourceId() is sometimes missing during import and I run into memory exhaustion issues... I'm not sure if it's connected with each other or not 🤔

Call to undefined method OCA\\ContactsInteraction\\AddressBook::getResourceId()

{"reqId":"OgTnmGJkVZnr3LXtUfGS","level":3,"time":"2026-07-02T12:55:03+00:00","remoteAddr":"192.168.21.6","user":"admin","app":"webdav","method":"GET","url":"/remote.php/dav/addressbooks/users/admin/z-app-generated--contactsinteraction--recent/4?photo","scriptName":"/remote.php","message":"Call to undefined method OCA\\ContactsInteraction\\AddressBook::getResourceId()","userAgent":"Mozilla/5.0 (X11; Linux x86_64; rv:152.0) Gecko/20100101 Firefox/152.0","version":"35.0.0.1","exception":{"Exception":"Error","Message":"Call to undefined method OCA\\ContactsInteraction\\AddressBook::getResourceId()","Code":0,"Trace":[{"file":"/var/www/html/3rdparty/sabre/event/lib/WildcardEmitterTrait.php","line":89,"function":"httpGet","class":"OCA\\DAV\\CardDAV\\ImageExportPlugin","type":"->","args":[{"__class__":"Sabre\\HTTP\\Request"},{"__class__":"Sabre\\HTTP\\Response"}]},{"file":"/var/www/html/3rdparty/sabre/dav/lib/DAV/Server.php","line":472,"function":"emit","class":"Sabre\\DAV\\Server","type":"->","args":["method:GET",[{"__class__":"Sabre\\HTTP\\Request"},{"__class__":"Sabre\\HTTP\\Response"}]]},{"file":"/var/www/html/apps/dav/lib/Connector/Sabre/Server.php","line":216,"function":"invokeMethod","class":"Sabre\\DAV\\Server","type":"->","args":[{"__class__":"Sabre\\HTTP\\Request"},{"__class__":"Sabre\\HTTP\\Response"}]},{"file":"/var/www/html/apps/dav/lib/Server.php","line":431,"function":"start","class":"OCA\\DAV\\Connector\\Sabre\\Server","type":"->","args":[]},{"file":"/var/www/html/apps/dav/appinfo/v2/remote.php","line":25,"function":"exec","class":"OCA\\DAV\\Server","type":"->","args":[]},{"file":"/var/www/html/remote.php","line":152,"args":["/var/www/html/apps/dav/appinfo/v2/remote.php"],"function":"require_once"}],"File":"/var/www/html/apps/dav/lib/CardDAV/ImageExportPlugin.php","Line":90,"message":"Call to undefined method OCA\\ContactsInteraction\\AddressBook::getResourceId()","exception":"{\"class\":\"Error\",\"message\":\"Call to undefined method OCA\\ContactsInteraction\\AddressBook::getResourceId()\",\"code\":0,\"file\":\"/var/www/html/apps/dav/lib/CardDAV/ImageExportPlugin.php:90\",\"trace\":\"#0 /var/www/html/3rdparty/sabre/event/lib/WildcardEmitterTrait.php(89): OCA\\DAV\\CardDAV\\ImageExportPlugin->httpGet(Object(Sabre\\HTTP\\Request), Object(Sabre\\HTTP\\Response))\\n#1 /var/www/html/3rdparty/sabre/dav/lib/DAV/Server.php(472): Sabre\\DAV\\Server->emit('method:GET', Array)\\n#2 /var/www/html/apps/dav/lib/Connector/Sabre/Server.php(216): Sabre\\DAV\\Server->invokeMethod(Object(Sabre\\HTTP\\Request), Object(Sabre\\HTTP\\Response))\\n#3 /var/www/html/apps/dav/lib/Server.php(431): OCA\\DAV\\Connector\\Sabre\\Server->start()\\n#4 /var/www/html/apps/dav/appinfo/v2/remote.php(25): OCA\\DAV\\Server->exec()\\n#5 /var/www/html/remote.php(152): require_once('/var/www/html/a...')\\n#6 {main}\"}","CustomMessage":"Call to undefined method OCA\\ContactsInteraction\\AddressBook::getResourceId()"}}

Memory exhausted

{"reqId":"3iMSiAmNrULlhfwSaiDO","level":3,"time":"2026-07-02T12:50:25+00:00","remoteAddr":"192.168.21.6","user":"admin","app":"PHP","method":"POST","url":"/ocs/v2.php/contacts/import","scriptName":"/ocs/v2.php","message":"Allowed memory size of 536870912 bytes exhausted (tried to allocate 20480 bytes) at /var/www/html/lib/private/DB/BacktraceDebugStack.php#17","userAgent":"Mozilla/5.0 (X11; Linux x86_64; rv:152.0) Gecko/20100101 Firefox/152.0","version":"35.0.0.1","data":{"app":"PHP"}}

And the following warning is being thrown sometimes at the end of the import:

Header already modified

{"reqId":"JB6VEaCQag0xFUSRnBht","level":2,"time":"2026-07-02T12:45:12+00:00","remoteAddr":"192.168.21.6","user":"--","app":"PHP","method":"GET","url":"/ocs/v2.php/core/update?requesttoken=U7cE4APNLGXov5ztfdWmRSwUhHYe5Org0dXwAUQs8RQ%3D%3AfINmkGy1HQ6Z8%2FOCP%2BHPNGNRwwRHkJ2zoeKaaCJPplc%3D","scriptName":"/ocs/v2.php","message":"Cannot modify header information - headers already sent at /var/www/html/lib/private/AppFramework/Http/Output.php#50","userAgent":"Mozilla/5.0 (X11; Linux x86_64; rv:152.0) Gecko/20100101 Firefox/152.0","version":"35.0.0.1","data":{"app":"PHP"}}
{"reqId":"JB6VEaCQag0xFUSRnBht","level":2,"time":"2026-07-02T12:45:12+00:00","remoteAddr":"192.168.21.6","user":"--","app":"PHP","method":"GET","url":"/ocs/v2.php/core/update?requesttoken=U7cE4APNLGXov5ztfdWmRSwUhHYe5Org0dXwAUQs8RQ%3D%3AfINmkGy1HQ6Z8%2FOCP%2BHPNGNRwwRHkJ2zoeKaaCJPplc%3D","scriptName":"/ocs/v2.php","message":"Cannot modify header information - headers already sent at /var/www/html/lib/private/AppFramework/Http/Output.php#50","userAgent":"Mozilla/5.0 (X11; Linux x86_64; rv:152.0) Gecko/20100101 Firefox/152.0","version":"35.0.0.1","data":{"app":"PHP"}}
{"reqId":"JB6VEaCQag0xFUSRnBht","level":2,"time":"2026-07-02T12:45:12+00:00","remoteAddr":"192.168.21.6","user":"--","app":"PHP","method":"GET","url":"/ocs/v2.php/core/update?requesttoken=U7cE4APNLGXov5ztfdWmRSwUhHYe5Org0dXwAUQs8RQ%3D%3AfINmkGy1HQ6Z8%2FOCP%2BHPNGNRwwRHkJ2zoeKaaCJPplc%3D","scriptName":"/ocs/v2.php","message":"Cannot modify header information - headers already sent at /var/www/html/lib/private/AppFramework/Http/Output.php#50","userAgent":"Mozilla/5.0 (X11; Linux x86_64; rv:152.0) Gecko/20100101 Firefox/152.0","version":"35.0.0.1","data":{"app":"PHP"}}
{"reqId":"JB6VEaCQag0xFUSRnBht","level":2,"time":"2026-07-02T12:45:12+00:00","remoteAddr":"192.168.21.6","user":"--","app":"PHP","method":"GET","url":"/ocs/v2.php/core/update?requesttoken=U7cE4APNLGXov5ztfdWmRSwUhHYe5Org0dXwAUQs8RQ%3D%3AfINmkGy1HQ6Z8%2FOCP%2BHPNGNRwwRHkJ2zoeKaaCJPplc%3D","scriptName":"/ocs/v2.php","message":"Cannot modify header information - headers already sent at /var/www/html/lib/private/AppFramework/Http/Output.php#50","userAgent":"Mozilla/5.0 (X11; Linux x86_64; rv:152.0) Gecko/20100101 Firefox/152.0","version":"35.0.0.1","data":{"app":"PHP"}}
{"reqId":"JB6VEaCQag0xFUSRnBht","level":2,"time":"2026-07-02T12:45:12+00:00","remoteAddr":"192.168.21.6","user":"--","app":"PHP","method":"GET","url":"/ocs/v2.php/core/update?requesttoken=U7cE4APNLGXov5ztfdWmRSwUhHYe5Org0dXwAUQs8RQ%3D%3AfINmkGy1HQ6Z8%2FOCP%2BHPNGNRwwRHkJ2zoeKaaCJPplc%3D","scriptName":"/ocs/v2.php","message":"Cannot modify header information - headers already sent at /var/www/html/lib/private/AppFramework/Http/Output.php#50","userAgent":"Mozilla/5.0 (X11; Linux x86_64; rv:152.0) Gecko/20100101 Firefox/152.0","version":"35.0.0.1","data":{"app":"PHP"}}
{"reqId":"JB6VEaCQag0xFUSRnBht","level":2,"time":"2026-07-02T12:45:12+00:00","remoteAddr":"192.168.21.6","user":"--","app":"PHP","method":"GET","url":"/ocs/v2.php/core/update?requesttoken=U7cE4APNLGXov5ztfdWmRSwUhHYe5Org0dXwAUQs8RQ%3D%3AfINmkGy1HQ6Z8%2FOCP%2BHPNGNRwwRHkJ2zoeKaaCJPplc%3D","scriptName":"/ocs/v2.php","message":"Cannot modify header information - headers already sent at /var/www/html/lib/private/AppFramework/Http/Output.php#50","userAgent":"Mozilla/5.0 (X11; Linux x86_64; rv:152.0) Gecko/20100101 Firefox/152.0","version":"35.0.0.1","data":{"app":"PHP"}}
{"reqId":"JB6VEaCQag0xFUSRnBht","level":2,"time":"2026-07-02T12:45:12+00:00","remoteAddr":"192.168.21.6","user":"--","app":"PHP","method":"GET","url":"/ocs/v2.php/core/update?requesttoken=U7cE4APNLGXov5ztfdWmRSwUhHYe5Org0dXwAUQs8RQ%3D%3AfINmkGy1HQ6Z8%2FOCP%2BHPNGNRwwRHkJ2zoeKaaCJPplc%3D","scriptName":"/ocs/v2.php","message":"Cannot modify header information - headers already sent at /var/www/html/lib/private/AppFramework/Http/Output.php#50","userAgent":"Mozilla/5.0 (X11; Linux x86_64; rv:152.0) Gecko/20100101 Firefox/152.0","version":"35.0.0.1","data":{"app":"PHP"}}
{"reqId":"JB6VEaCQag0xFUSRnBht","level":2,"time":"2026-07-02T12:45:12+00:00","remoteAddr":"192.168.21.6","user":"--","app":"PHP","method":"GET","url":"/ocs/v2.php/core/update?requesttoken=U7cE4APNLGXov5ztfdWmRSwUhHYe5Org0dXwAUQs8RQ%3D%3AfINmkGy1HQ6Z8%2FOCP%2BHPNGNRwwRHkJ2zoeKaaCJPplc%3D","scriptName":"/ocs/v2.php","message":"Cannot modify header information - headers already sent at /var/www/html/lib/private/AppFramework/Http/Output.php#50","userAgent":"Mozilla/5.0 (X11; Linux x86_64; rv:152.0) Gecko/20100101 Firefox/152.0","version":"35.0.0.1","data":{"app":"PHP"}}
{"reqId":"JB6VEaCQag0xFUSRnBht","level":2,"time":"2026-07-02T12:45:12+00:00","remoteAddr":"192.168.21.6","user":"--","app":"PHP","method":"GET","url":"/ocs/v2.php/core/update?requesttoken=U7cE4APNLGXov5ztfdWmRSwUhHYe5Org0dXwAUQs8RQ%3D%3AfINmkGy1HQ6Z8%2FOCP%2BHPNGNRwwRHkJ2zoeKaaCJPplc%3D","scriptName":"/ocs/v2.php","message":"Cannot modify header information - headers already sent at /var/www/html/lib/private/AppFramework/Http/Output.php#50","userAgent":"Mozilla/5.0 (X11; Linux x86_64; rv:152.0) Gecko/20100101 Firefox/152.0","version":"35.0.0.1","data":{"app":"PHP"}}
{"reqId":"JB6VEaCQag0xFUSRnBht","level":2,"time":"2026-07-02T12:45:12+00:00","remoteAddr":"192.168.21.6","user":"--","app":"PHP","method":"GET","url":"/ocs/v2.php/core/update?requesttoken=U7cE4APNLGXov5ztfdWmRSwUhHYe5Org0dXwAUQs8RQ%3D%3AfINmkGy1HQ6Z8%2FOCP%2BHPNGNRwwRHkJ2zoeKaaCJPplc%3D","scriptName":"/ocs/v2.php","message":"Cannot modify header information - headers already sent at /var/www/html/lib/private/AppFramework/Http/Output.php#50","userAgent":"Mozilla/5.0 (X11; Linux x86_64; rv:152.0) Gecko/20100101 Firefox/152.0","version":"35.0.0.1","data":{"app":"PHP"}}
{"reqId":"JB6VEaCQag0xFUSRnBht","level":2,"time":"2026-07-02T12:45:12+00:00","remoteAddr":"192.168.21.6","user":"--","app":"PHP","method":"GET","url":"/ocs/v2.php/core/update?requesttoken=U7cE4APNLGXov5ztfdWmRSwUhHYe5Org0dXwAUQs8RQ%3D%3AfINmkGy1HQ6Z8%2FOCP%2BHPNGNRwwRHkJ2zoeKaaCJPplc%3D","scriptName":"/ocs/v2.php","message":"Cannot modify header information - headers already sent at /var/www/html/lib/private/AppFramework/Http/Output.php#50","userAgent":"Mozilla/5.0 (X11; Linux x86_64; rv:152.0) Gecko/20100101 Firefox/152.0","version":"35.0.0.1","data":{"app":"PHP"}}

SebastianKrupinski · 2026-07-02T20:44:58Z

Hey David, Thanks for testing!

Looks like some of these are not related to my PR.

Call to undefined method OCA\ContactsInteraction\AddressBook::getResourceId()
is being triggered by "method":"GET","url":"/remote.php/dav/addressbooks/users/admin/z-app-generated--contactsinteraction--recent/4?photo" thats contacts downloading a photo.
Header already modified
is being triggered by "method":"GET","url":"/ocs/v2.php/core/update?requesttoken=U7cE4APNLGXov5ztfdWmRSwUhHYe5Org0dXwAUQs8RQ%3D%3AfINmkGy1HQ6Z8%2FOCP%2BHPNGNRwwRHkJ2zoeKaaCJPplc%3D" that looks like some kind of token update, not related to the new end point as far as I know.
Memory exhausted
This does seem to be related to the new end point but there is no stack trace... and the memory exhaustion seems to be happening in a unrelated file... "/var/www/html/lib/private/DB/BacktraceDebugStack.php" I will have a look in to this

Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>

SebastianKrupinski · 2026-07-14T18:12:35Z

@DerDreschner

So I tracked down the memory exhaustion error and its not related to this PR, its happening at the request parsing level. Therefore unrelated and out of scope

{
  "reqId": "5ZpYtIpPF99gzyZwwRTN",
  "level": 3,
  "time": "2026-07-14T18:08:22+00:00",
  "remoteAddr": "127.0.0.1",
  "user": "user1",
  "app": "PHP",
  "method": "POST",
  "url": "/ocs/v2.php/contacts/import",
  "scriptName": "/ocs/v2.php",
  "message": "Allowed memory size of 134217728 bytes exhausted (tried to allocate 66543648 bytes) at /var/www/nextcloud/master/lib/private/AppFramework/Http/Request.php#387",
  "userAgent": "Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:152.0) Gecko/20100101 Firefox/152.0",
  "version": "35.0.0.1",
  "data": {
    "app": "PHP"
  }
}

Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>

SebastianKrupinski self-assigned this Jun 13, 2026

SebastianKrupinski added the 2. developing Work in progress label Jun 13, 2026

SebastianKrupinski added this to 💌 📅 👥 Groupware team Jun 13, 2026

github-project-automation Bot moved this to 🏗️ In progress in 💌 📅 👥 Groupware team Jun 13, 2026

SebastianKrupinski force-pushed the feat/contacts-import-ocs branch from 9e175b9 to 7553769 Compare June 24, 2026 19:27

SebastianKrupinski added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jun 24, 2026

SebastianKrupinski mentioned this pull request Jun 24, 2026

fix: import nextcloud/contacts#5386

Open

SebastianKrupinski added this to the Nextcloud 35 milestone Jun 24, 2026

SebastianKrupinski marked this pull request as ready for review June 24, 2026 19:33

SebastianKrupinski requested review from a team and hamza221 as code owners June 24, 2026 19:33

SebastianKrupinski requested review from ArtificialOwl, ChristophWurst, come-nc, icewind1991 and leftybournes and removed request for a team June 24, 2026 19:33

ChristophWurst reviewed Jun 25, 2026

View reviewed changes

ChristophWurst added enhancement feature: dav feature: carddav Related to CardDAV internals labels Jun 29, 2026

DerDreschner reviewed Jul 2, 2026

View reviewed changes

SebastianKrupinski force-pushed the feat/contacts-import-ocs branch from c171464 to 90e83f0 Compare July 14, 2026 14:02

SebastianKrupinski requested review from a team, blizzz, nickvergessen and tcitworld as code owners July 14, 2026 14:02

SebastianKrupinski requested review from a team, danxuliu, julien-nc, mejo-, mgallien, miaulalala, nfebe, provokateurin and skjnldsv as code owners July 14, 2026 14:02

SebastianKrupinski force-pushed the feat/calendar-import-export-ocs branch from d0e8053 to 4d7c277 Compare July 14, 2026 14:06

SebastianKrupinski force-pushed the feat/contacts-import-ocs branch from 90e83f0 to 60a348c Compare July 14, 2026 14:08

SebastianKrupinski force-pushed the feat/calendar-import-export-ocs branch from 4d7c277 to 085f3d4 Compare July 14, 2026 17:35

SebastianKrupinski added 2 commits July 14, 2026 13:36

feat: contacts import ocs

a23acb0

Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>

fixup! feat: contacts import ocs

875d2e6

Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>

SebastianKrupinski force-pushed the feat/contacts-import-ocs branch 2 times, most recently from 6de1791 to 3b8c00a Compare July 14, 2026 17:51

fixup! feat: contacts import ocs

d7ed0f7

Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>

SebastianKrupinski force-pushed the feat/contacts-import-ocs branch from 3b8c00a to d7ed0f7 Compare July 14, 2026 18:30

ChristophWurst mentioned this pull request Jul 15, 2026

feat: OCS Calendar Import #55178

Open

4 tasks


		use JsonSerializable;

		interface ImportEvent extends JsonSerializable {

Uh oh!

Uh oh!

Conversation

SebastianKrupinski commented Jun 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

AI (if applicable)

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

SebastianKrupinski Jul 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

DerDreschner commented Jul 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

SebastianKrupinski commented Jul 2, 2026

Uh oh!

SebastianKrupinski commented Jul 14, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

SebastianKrupinski commented Jun 13, 2026 •

edited

Loading

SebastianKrupinski Jul 14, 2026 •

edited

Loading

DerDreschner commented Jul 2, 2026 •

edited

Loading