fix(cache): make clear() redis cluster compatible#61559
Merged
Conversation
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
solracsf
marked this pull request as ready for review
June 23, 2026 21:44
solracsf
requested review from
Altahrim,
ArtificialOwl,
leftybournes and
provokateurin
and removed request for
a team
June 23, 2026 21:44
solracsf
added
3. to review
susnux
reviewed
Jul 14, 2026
| ); | ||
|
|
||
| return $this->wrappedCache->cad($key, $old); | ||
| return $this->wrappedCache->ncad($key, $old); |
Contributor
There was a problem hiding this comment.
Looks unrelated to redis, so should better be on its on PR for logical separation.
At least in its own commit.
Member
Author
There was a problem hiding this comment.
Yep, will open a separate PR.
Contributor
|
/backport to stable34 |
Contributor
|
/backport to stable33 |
7 tasks
provokateurin
approved these changes
Jul 15, 2026
provokateurin
enabled auto-merge
July 15, 2026 06:06
This was referenced Jul 15, 2026
Contributor
|
/backport to stable32 |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
clear()now uses SCAN + UNLINK instead of KEYS + DEL. Added a cluster-aware branch: iterates each master via_masters()and unlinks keys one at a time so every command stays within a single hash slot, soclear()now actually works as expected on a Redis Cluster.Aditionnally,
LoggerWrapperCache::ncad()now correctly delegates toncad().Note: The
@psalm-suppress NullArgument, PossiblyNullArgumenton the SCAN calls is required because the phpredis stub types the cursor as int though it must start as null.Checklist
3. to review, feature component)stable32)AI (if applicable)