Skip to content

fix(files_external): ignore deprecated backends#61568

Merged
leftybournes merged 1 commit into
masterfrom
leftybournes/fix/files_external-ignore-deprecated-backends
Jul 1, 2026
Merged

fix(files_external): ignore deprecated backends#61568
leftybournes merged 1 commit into
masterfrom
leftybournes/fix/files_external-ignore-deprecated-backends

Conversation

@leftybournes

Copy link
Copy Markdown
Member
  • Resolves: #

Summary

Deprecated external storage backends used to be ignored but are being shown again. This fixes it so that they're ignored.

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

Signed-off-by: Kent Delante <kent@delante.me>
@leftybournes leftybournes added this to the Nextcloud 35 milestone Jun 24, 2026
@leftybournes leftybournes requested a review from a team as a code owner June 24, 2026 13:07
@leftybournes leftybournes removed the request for review from a team June 24, 2026 13:07
@leftybournes leftybournes added the 3. to review Waiting for reviews label Jun 24, 2026
@joshtrichards

Copy link
Copy Markdown
Member

Any idea when this changed? It's been like this for awhile from what I can tell.

@leftybournes

Copy link
Copy Markdown
Member Author

@joshtrichards

It changed in stable33 during the vue migration. It used to be ignored before that.

https://github.com/nextcloud/server/blob/stable32/apps/files_external/templates/settings.php#L109-L111

@come-nc come-nc removed their request for review June 29, 2026 15:26
@leftybournes leftybournes enabled auto-merge July 1, 2026 12:20
@leftybournes leftybournes merged commit d8a7702 into master Jul 1, 2026
247 of 257 checks passed
@leftybournes leftybournes deleted the leftybournes/fix/files_external-ignore-deprecated-backends branch July 1, 2026 12:31
@leftybournes

Copy link
Copy Markdown
Member Author

/backport to stable34

@leftybournes

Copy link
Copy Markdown
Member Author

/backport to stable33

@backportbot

backportbot Bot commented Jul 1, 2026

Copy link
Copy Markdown

The backport to stable33 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable33
git pull origin stable33

# Create the new backport branch
git checkout -b backport/61568/stable33

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick e71d3e51

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/61568/stable33

Error: Failed to check for changes with origin/stable33: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@leftybournes

Copy link
Copy Markdown
Member Author

/backport to stable33

@backportbot

backportbot Bot commented Jul 1, 2026

Copy link
Copy Markdown

The backport to stable33 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable33
git pull origin stable33

# Create the new backport branch
git checkout -b backport/61568/stable33

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick e71d3e51

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/61568/stable33

Error: Failed to check for changes with origin/stable33: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants