Skip to content

fix(LoginForm): improve login throttle warning wording#61636

Merged
AndyScherzinger merged 2 commits into
nextcloud:masterfrom
MHJanny:fix/login-warning-wording
Jun 29, 2026
Merged

fix(LoginForm): improve login throttle warning wording#61636
AndyScherzinger merged 2 commits into
nextcloud:masterfrom
MHJanny:fix/login-warning-wording

Conversation

@MHJanny

@MHJanny MHJanny commented Jun 28, 2026

Copy link
Copy Markdown
Contributor

Summary

Changed the login throttle warning to be more user-friendly and less technical.

TODO

  • Update message in LoginForm.vue

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Tests (not needed - text only change)
  • Screenshots before/after (optional but nice)
  • Documentation not required
  • Backports requested
  • Labels added
  • Milestone added

@MHJanny MHJanny requested a review from a team as a code owner June 28, 2026 16:27
@MHJanny MHJanny requested review from nfebe, sorbaugh and susnux and removed request for a team June 28, 2026 16:27
@susnux susnux requested a review from rakekniven June 28, 2026 18:37
@susnux susnux added design Design, UI, UX, etc. 3. to review Waiting for reviews feature: language/translations (l10n/i18n) Localization and translation matters labels Jun 28, 2026
@susnux susnux added this to the Nextcloud 35 milestone Jun 28, 2026
@joshtrichards

Copy link
Copy Markdown
Member

/compile

@susnux susnux added the community pull requests from community label Jun 29, 2026
@susnux

susnux commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

@MHJanny please do not merge master into your branch but rather rebase onto master.

Also to get this merged please rebase and then compile the assets (run npm ci && npm run build and then commit the changes in dist as a new commit).

MHJanny added 2 commits June 29, 2026 20:34
Signed-off-by: Mehedi Hasan Janny <26045285+MHJanny@users.noreply.github.com>
@MHJanny MHJanny force-pushed the fix/login-warning-wording branch from 10521bf to 9fbfe71 Compare June 29, 2026 14:51
@MHJanny

MHJanny commented Jun 29, 2026

Copy link
Copy Markdown
Contributor Author

Rebased onto master and recompiled assets as requested.

@AndyScherzinger AndyScherzinger merged commit f43b4c4 into nextcloud:master Jun 29, 2026
146 of 152 checks passed
@welcome

welcome Bot commented Jun 29, 2026

Copy link
Copy Markdown

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

@rakekniven

Copy link
Copy Markdown
Member

Backport necessary?

@susnux

susnux commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

/backport to stable34

@github-actions

Copy link
Copy Markdown
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews community pull requests from community design Design, UI, UX, etc. feature: language/translations (l10n/i18n) Localization and translation matters feedback-requested

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Better wording for login warning

5 participants