fix: adjust file picker for background image to allow folder navigation#61688
Conversation
|
If possible it would be really great to have a small PlayWright test for this |
3fdc544 to
2763885
Compare
|
@susnux @pringelmann small test added. This is the first Playwright test I wrote, would appreciate some feedback. |
2763885 to
07cdbe2
Compare
Signed-off-by: Cristian Scheid <cristianscheid@gmail.com>
07cdbe2 to
44dfb36
Compare
|
/compile amend/ |
…ile picker Signed-off-by: Cristian Scheid <cristianscheid@gmail.com> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
44dfb36 to
1f1928d
Compare
|
@susnux should we backport this down to stable32? |
|
/backport to stable34 |
|
/backport to stable33 |
|
/backport to stable32 |
|
The backport to # Switch to the target branch and update it
git checkout stable32
git pull origin stable32
# Create the new backport branch
git checkout -b backport/61688/stable32
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 15c336f4 1f1928df
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/61688/stable32Error: Failed to check for changes with origin/stable32: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
backport to |
Summary
Currently, the file picker to change user background (under
settings/user/theming) does not allow to navigate folders when searching for a file. Instead, it only shows files from root directory on "All files" tab.This happens because of
setFilter((node) => node.mime.startsWith('image/')), which causes folders to be filtered out from results. This PR changes this line to usesetMimeTypeFilter(['image/*']), which allows to navigate folders while mantaining the filter to only allow image selection.Screenshots
Checklist
3. to review, feature component)stable32)AI (if applicable)