perf: Don't fetch full group object in AuthorizedGroupMapper#61838
Merged
Conversation
CarlSchwan
requested review from
ArtificialOwl,
come-nc,
leftybournes and
provokateurin
and removed request for
a team
come-nc
approved these changes
Jul 6, 2026
come-nc
left a comment
come-nc
left a comment
Contributor
There was a problem hiding this comment.
This screams that we should have a LazyGroup feature like LazyUser.
Altahrim
approved these changes
Jul 6, 2026
provokateurin
approved these changes
Jul 6, 2026
This is very expensive when multiple group backends are enabled as we don't cache which groups is included in which backend unlike in the User Manager. Signed-off-by: Carl Schwan <carlschwan@kde.org>
CarlSchwan
force-pushed
the
carl/perf/groupmapper
branch
from
affb400 to
636aaf7
Compare
Member
Author
|
/backport to stable34 |
Member
Author
|
/backport to stable33 |
Member
Author
|
/backport to stable32 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is very expensive when multiple group backends are enabled as we don't cache which groups is included in which backend unlike in the User Manager.
TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)