Skip to content

fix: Catch expected NotFoundException#61917

Merged
Altahrim merged 1 commit into
masterfrom
bug/noid/catch-exception
Jul 10, 2026
Merged

fix: Catch expected NotFoundException#61917
Altahrim merged 1 commit into
masterfrom
bug/noid/catch-exception

Conversation

@kesselb

@kesselb kesselb commented Jul 8, 2026 •
edited by solracsf
Loading

Copy link
Copy Markdown
Contributor

Summary

The method was catching the wrong exception.

  • Create public share link for a folder
  • Copy the share token
  • Send http request like below (set dir to a value that wont exist)
  • 💥
POST https://server99.internal/index.php/apps/files_sharing/shareinfo?dir=test123
Content-Type: application/x-www-form-urlencoded

t=share_token

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@kesselb
fix: Catch expected NotFoundException
c536052 
Assisted-by: ClaudeCode:claude-sonnet-5
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
@kesselb kesselb requested a review from a team as a code owner July 8, 2026 15:51
@kesselb kesselb requested review from CarlSchwan, icewind1991, leftybournes and salmart-dev and removed request for a team July 8, 2026 15:51
@kesselb kesselb self-assigned this Jul 8, 2026
@kesselb kesselb added bug 3. to review Waiting for reviews and removed AI assisted labels Jul 8, 2026
@Altahrim Altahrim merged commit 3aac8be into master Jul 10, 2026
232 of 245 checks passed
@Altahrim Altahrim deleted the bug/noid/catch-exception branch July 10, 2026 09:15
@CarlSchwan

CarlSchwan commented Jul 10, 2026

Copy link
Copy Markdown
Member

/backport to stable34

@CarlSchwan

CarlSchwan commented Jul 10, 2026

Copy link
Copy Markdown
Member

/backport to stable33

@backportbot backportbot Bot mentioned this pull request Jul 10, 2026
Merged
@backportbot backportbot Bot mentioned this pull request Jul 10, 2026
Merged
@solracsf solracsf added this to the Nextcloud 35 milestone Jul 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Altahrim Altahrim Altahrim approved these changes
@CarlSchwan CarlSchwan CarlSchwan approved these changes
@icewind1991 icewind1991 Awaiting requested review from icewind1991 icewind1991 is a code owner automatically assigned from nextcloud/server-backend
@salmart-dev salmart-dev Awaiting requested review from salmart-dev salmart-dev is a code owner automatically assigned from nextcloud/server-backend
@leftybournes leftybournes Awaiting requested review from leftybournes leftybournes is a code owner automatically assigned from nextcloud/server-backend

Assignees

@kesselb kesselb

Labels

3. to review Waiting for reviews bug

Projects

None yet

Milestone

Nextcloud 35

Development

Successfully merging this pull request may close these issues.

5 participants

@kesselb @CarlSchwan @Altahrim @solracsf @nextcloud-command