feat(login): clean remember me tokens#61944
Merged
Merged
Conversation
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
Altahrim
added
2. developing
Altahrim
requested review from
ArtificialOwl,
leftybournes,
provokateurin and
salmart-dev
and removed request for
a team
Collaborator
Author
|
/backport to stable34 |
provokateurin
approved these changes
Jul 9, 2026
Collaborator
Author
|
/backport to stable33 |
Collaborator
Author
|
/backport to stable32 |
This was referenced Jul 10, 2026
| $qb | ||
| ->delete() | ||
| ->where($qb->expr()->eq('appid', $qb->expr()->literal('login_token'))) | ||
| ->andWhere($qb->expr()->lt('configvalue', $qb->createNamedParameter(time() - $rememberMeMaxAge))) |
Member
There was a problem hiding this comment.
from running such query manually I remember that Postgres (and probably oracle) are more strict about the fact that configvalue is VARCHAR and used in a comparison with an INT here
Collaborator
Author
There was a problem hiding this comment.
This query was tested with PostgreSQL 17.6:
DELETE FROM oc_preferences
WHERE appid = 'login_token' AND configvalue < 1777632074;Do you think it may have changed with new versions?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
oc_preferences#61753Summary
Remember me cookie lifetime is 15 days by default, but they are never deleted in database.
Checklist
3. to review, feature component)stable32)AI (if applicable)